You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2022/12/06 10:46:16 UTC

[GitHub] [activemq-artemis] gtully opened a new pull request, #4306: ARTEMIS-4042 - remove use of codec system property from scripts as en…

gtully opened a new pull request, #4306:
URL: https://github.com/apache/activemq-artemis/pull/4306

   …v var can now be read directly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #4306: ARTEMIS-4042 - remove use of codec system property from scripts as en…

Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #4306:
URL: https://github.com/apache/activemq-artemis/pull/4306#issuecomment-1339220539

   > @gemmellr has this any implications for the new upgrade scripts that I am missing? Functionally there is no behaviour change so I think not.
   
   I dont believe so, it should just 'remove' this as desired, if present in the old file, by virtue of it no longer being in the current file. Easy enough to check the output of an upgrade (or look at the tests) to confirm though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gtully commented on pull request #4306: ARTEMIS-4042 - remove use of codec system property from scripts as en…

Posted by GitBox <gi...@apache.org>.
gtully commented on PR #4306:
URL: https://github.com/apache/activemq-artemis/pull/4306#issuecomment-1342882603

   new jira https://issues.apache.org/jira/browse/ARTEMIS-4112 - thanks for the feedback


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gemmellr commented on pull request #4306: ARTEMIS-4042 - remove use of codec system property from scripts as en…

Posted by GitBox <gi...@apache.org>.
gemmellr commented on PR #4306:
URL: https://github.com/apache/activemq-artemis/pull/4306#issuecomment-1339216606

   This should have its own JIRA for tracking the change, not reusing an existing already released one; the earlier change on the 4042 JIRA has been in 2 previous releases already.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gtully commented on pull request #4306: ARTEMIS-4042 - remove use of codec system property from scripts as en…

Posted by GitBox <gi...@apache.org>.
gtully commented on PR #4306:
URL: https://github.com/apache/activemq-artemis/pull/4306#issuecomment-1339130533

   @gemmellr has this any implications for the new upgrade scripts that I am missing? Functionally there is no behaviour change so I think not.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] gtully merged pull request #4306: ARTEMIS-4042 - remove use of codec system property from scripts as en…

Posted by GitBox <gi...@apache.org>.
gtully merged PR #4306:
URL: https://github.com/apache/activemq-artemis/pull/4306


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org