You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/09 17:51:49 UTC
[GitHub] [airflow] andriisoldatenko opened a new pull request #18121: fix misspelling
andriisoldatenko opened a new pull request #18121:
URL: https://github.com/apache/airflow/pull/18121
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] andriisoldatenko commented on pull request #18121: [AIRFLOW-XXX] fix misspelling in docs/
Posted by GitBox <gi...@apache.org>.
andriisoldatenko commented on pull request #18121:
URL: https://github.com/apache/airflow/pull/18121#issuecomment-916369200
@ashb can you point me i can create separate PR with adding to pre commit check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #18121: [AIRFLOW-XXX] fix misspelling in docs/
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #18121:
URL: https://github.com/apache/airflow/pull/18121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18121: [AIRFLOW-XXX] fix misspelling in docs/
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18121:
URL: https://github.com/apache/airflow/pull/18121#issuecomment-916317940
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18121: [AIRFLOW-XXX] fix misspelling in docs/
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18121:
URL: https://github.com/apache/airflow/pull/18121#issuecomment-916890022
> @ashb can you point me i can create separate PR with adding to pre commit check.
Pre-commit here: https://github.com/apache/airflow/blob/main/.pre-commit-config.yaml
Likely there is an existing pre-commit hook that you can add, or if not it can be added either as "system" or "python" pre-commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #18121: [AIRFLOW-XXX] fix misspelling in docs/
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #18121:
URL: https://github.com/apache/airflow/pull/18121#issuecomment-916323079
Misspel might be interesting as a precommit check coupled with our existing spell list, yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org