You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by GitBox <gi...@apache.org> on 2019/10/30 16:09:07 UTC
[GitHub] [metron] mmiklavc commented on a change in pull request #1547:
METRON-2302: [UI] Change the default polling interval for Alerts UI to
longer time
mmiklavc commented on a change in pull request #1547: METRON-2302: [UI] Change the default polling interval for Alerts UI to longer time
URL: https://github.com/apache/metron/pull/1547#discussion_r340713898
##########
File path: metron-interface/metron-alerts/src/app/alerts/alerts-list/auto-polling/auto-polling.service.spec.ts
##########
@@ -486,18 +489,18 @@ describe('AutoPollingService', () => {
expect(searchServiceFake.search).toHaveBeenCalledTimes(1);
- tick(getIntervalInMS());
+ tick(localAutoPollingSvc.getInterval() * 1000);
Review comment:
You may want to consider normalizing your abstraction for the tick calculations, i.e. you're using a nice function `getIntervalInMS()` in some places, but removed it here bc you're using a `localAutoPollingSvc` rather than the global `autoPollingService`. Not a blocker, but something to consider if you're inclined.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services