You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2016/11/24 06:44:12 UTC
[GitHub] zeppelin pull request #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -Ds...
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1673
ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTests
### What is this PR for?
Skip PhatomJS installation on `mvn package -DskipTests`
### What type of PR is it?
Improvement
### What is the Jira issue?
[ZEPPELIN-1703](https://issues.apache.org/jira/browse/ZEPPELIN-1703)
### How should this be tested?
`mvn package -DskipTests -pl zeppelin-web` and see no PhantomJS mentions in output.
`mvn package -pl zeppelin-web` and see that PhantomJS is installed\run.
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bzz/incubator-zeppelin feat/skip-phantomjs-on-mvn-skip-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1673.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1673
----
commit a5355ae976b53e7d5c0baa8400dadae079ba6e54
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2016-11-24T06:41:02Z
ZEPPELIN-1703: skip PhantomJS on -DskipTests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -Ds...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1673
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1673
Thanks for review @1ambda ! Not sure about version number, so kept it blank for now..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1673
Tested and LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1673
\cc @afsanjar @felizbaer for reivew
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Posted by asanjar <gi...@git.apache.org>.
Github user asanjar commented on the issue:
https://github.com/apache/zeppelin/pull/1673
+1 thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1673
Thank you @Leemoonsoo ! Merging to master, if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1673
LGTM! It significant improvement.
mvn package -pl zeppelin-web
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:02 min
[INFO] Finished at: 2016-11-25T10:58:49+05:30
[INFO] Final Memory: 37M/800M
[INFO] ------------------------------------------------------------------------
```
mvn package -DskipTests -pl zeppelin-web
```
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 01:17 min
[INFO] Finished at: 2016-11-25T11:00:13+05:30
[INFO] Final Memory: 34M/653M
[INFO] ------------------------------------------------------------------------
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Posted by felizbear <gi...@git.apache.org>.
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1673
@bzz it's definitely the simplest solution I'm aware of. it increases `npm test` time since it tries to install phantom every time you run it, but that's fine I guess. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1673
@bzz I think this is cool. This will reduce build time for profiles do not test
If we worry about version, we could specify in `pretest` command like `npm install karma-phantomjs-launcher@1.0.2`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1673: ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTest...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1673
Thank you for review @felizbear !
> it increases npm test time since it tries to install phantom every time
but it reduces `npm install` time, and as soon as on CI we only do install\test once - total time should be the same.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---