You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/01/16 12:18:41 UTC

[GitHub] [incubator-nuttx] anchao opened a new pull request #2696: sim/hcitty: add hcitty adapter

anchao opened a new pull request #2696:
URL: https://github.com/apache/incubator-nuttx/pull/2696


   
   ## Summary
   
   sim/hcitty: add hcitty adapter
   
   add support to attach the devices via HCI TTY to Bluetooth Host
   
   Reference:
   
   drivers/wireless/bluetooth/bt_uart_shim.c
   
   Signed-off-by: chao.an <an...@xiaomi.com>
   
   ## Impact
   
   N/A
   
   ## Testing
   
   attach the devices via HCI TTY to Bluetooth Host


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #2696: sim/hcitty: add hcitty adapter

Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #2696:
URL: https://github.com/apache/incubator-nuttx/pull/2696#discussion_r559072192



##########
File path: arch/sim/Kconfig
##########
@@ -531,16 +531,31 @@ config SIM_QSPIFLASH_PAGESIZE
 		"wrap" causing the initial data sent to be overwritten.
 		This is consistent with standard SPI FLASH operation.
 
+choice
+	prompt "Simulated Prototype of HCI"
+	default SIM_HCISOCKET
+	depends on (HOST_LINUX && SIM_WALLTIME)

Review comment:
       I will remove the choice option




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #2696: sim/hcitty: add hcitty adapter

Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #2696:
URL: https://github.com/apache/incubator-nuttx/pull/2696#discussion_r559072257



##########
File path: arch/sim/Kconfig
##########
@@ -531,16 +531,31 @@ config SIM_QSPIFLASH_PAGESIZE
 		"wrap" causing the initial data sent to be overwritten.
 		This is consistent with standard SPI FLASH operation.
 
+choice

Review comment:
       Yes, I will remove the choice option




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2696: sim/hcitty: add hcitty adapter

Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #2696:
URL: https://github.com/apache/incubator-nuttx/pull/2696#discussion_r558950888



##########
File path: arch/sim/Kconfig
##########
@@ -531,16 +531,31 @@ config SIM_QSPIFLASH_PAGESIZE
 		"wrap" causing the initial data sent to be overwritten.
 		This is consistent with standard SPI FLASH operation.
 
+choice
+	prompt "Simulated Prototype of HCI"
+	default SIM_HCISOCKET
+	depends on (HOST_LINUX && SIM_WALLTIME)
+
 config SIM_HCISOCKET
 	bool "Attach Host Bluetooth"
-	default false
-	depends on (WIRELESS_BLUETOOTH && HOST_LINUX && SIM_WALLTIME)
+	depends on WIRELESS_BLUETOOTH
+	---help---
+		Attached the local bluetooth device to the simulation
+		target via HCI_CHANNEL_USER. This gives NuttX full
+		control of the device, but is abstracted from the
+		physical interface which is still handled by Linux.

Review comment:
       this just repeats the help message of the other related option. please update it to reflect what it actually does different




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2696: sim/hcitty: add hcitty adapter

Posted by GitBox <gi...@apache.org>.
v01d commented on a change in pull request #2696:
URL: https://github.com/apache/incubator-nuttx/pull/2696#discussion_r558952853



##########
File path: arch/sim/Kconfig
##########
@@ -531,16 +531,31 @@ config SIM_QSPIFLASH_PAGESIZE
 		"wrap" causing the initial data sent to be overwritten.
 		This is consistent with standard SPI FLASH operation.
 
+choice
+	prompt "Simulated Prototype of HCI"
+	default SIM_HCISOCKET
+	depends on (HOST_LINUX && SIM_WALLTIME)

Review comment:
       this enables something that should not be enabled by default. this choice should be an option that you can choose to turn on or not. simply add one "none" option and make it default.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2696: sim/hcitty: add hcitty adapter

Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2696:
URL: https://github.com/apache/incubator-nuttx/pull/2696#discussion_r559010786



##########
File path: arch/sim/Kconfig
##########
@@ -531,16 +531,31 @@ config SIM_QSPIFLASH_PAGESIZE
 		"wrap" causing the initial data sent to be overwritten.
 		This is consistent with standard SPI FLASH operation.
 
+choice

Review comment:
       I don't think this should be choice as the options are not exclusive.   I don't see anything in the driver that would prevent you from exposing HCI0 as a tty device and HCI1 to the NuttX network stack. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton merged pull request #2696: sim/hcitty: add hcitty adapter

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2696:
URL: https://github.com/apache/incubator-nuttx/pull/2696


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #2696: sim/hcitty: add hcitty adapter

Posted by GitBox <gi...@apache.org>.
anchao commented on a change in pull request #2696:
URL: https://github.com/apache/incubator-nuttx/pull/2696#discussion_r559071567



##########
File path: arch/sim/Kconfig
##########
@@ -531,16 +531,31 @@ config SIM_QSPIFLASH_PAGESIZE
 		"wrap" causing the initial data sent to be overwritten.
 		This is consistent with standard SPI FLASH operation.
 
+choice
+	prompt "Simulated Prototype of HCI"
+	default SIM_HCISOCKET
+	depends on (HOST_LINUX && SIM_WALLTIME)
+
 config SIM_HCISOCKET
 	bool "Attach Host Bluetooth"
-	default false
-	depends on (WIRELESS_BLUETOOTH && HOST_LINUX && SIM_WALLTIME)
+	depends on WIRELESS_BLUETOOTH
+	---help---
+		Attached the local bluetooth device to the simulation
+		target via HCI_CHANNEL_USER. This gives NuttX full
+		control of the device, but is abstracted from the
+		physical interface which is still handled by Linux.

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org