[GitHub] [beam] JayDosunmu commented on a change in pull request #15478: [BEAM-12856] Change hard-coded limits for reading from a UnboundedReader to be configurable by options.

[GitBox <gi...@apache.org>]

JayDosunmu commented on a change in pull request #15478:
URL: https://github.com/apache/beam/pull/15478#discussion_r724445775



##########
File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineDebugOptions.java
##########
@@ -230,6 +230,28 @@ public Dataflow create(PipelineOptions options) {
 
   void setReaderCacheTimeoutSec(Integer value);
 
+  /** The max amount of time an UnboundedReader is consumed before checkpointing. */
+  @Description(
+      "The max amount of time before an UnboundedReader is consumed before checkpointing, in seconds.")
+  @Default.Integer(10)
+  Integer getUnboundedReaderMaxReadTimeSec();
+
+  void setUnboundedReaderMaxReadTimeSec(Integer value);
+
+  /** The max elements read from an UnboundedReader before checkpointing. */
+  @Description("The max elements read from an UnboundedReader before checkpointing. ")
+  @Default.Integer(10 * 1000)

Review comment:
       @scwhittle Just a heads up, in Java, you can use underscores in numbers i.e. 10_000. This may be useful in the future




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org