[GitHub] [helix] jiajunwang commented on a change in pull request #677: Add method to wait and return established session's ID

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #677: Add method to wait and return established session's ID
URL: https://github.com/apache/helix/pull/677#discussion_r364973553
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
 ##########
 @@ -2136,4 +2146,24 @@ public int hashCode() {
       return _listener.hashCode();
     }
   }
+
+  private void validateCurrentThread() {
+    if (_zookeeperEventThread != null && Thread.currentThread() == _zookeeperEventThread) {
+      throw new IllegalArgumentException("Must not be done in the zookeeper event thread.");
+    }
+  }
+
+  private void waitForKeeperStateUntilDeadline(KeeperState keeperState, Date deadline) {
 
 Review comment:
   Why not put the lock/check current thread logic inside this method as well?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org