You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Gary Gregory <ga...@gmail.com> on 2018/01/05 21:10:23 UTC
Getters for DefaultHttpServerIODispatch
Hi All,
Are there any objects to my adding getters for:
org.apache.http.impl.nio.DefaultHttpServerIODispatch.connFactory
org.apache.http.impl.nio.DefaultHttpServerIODispatch.handler
I need to get the handler I stick in a DefaultHttpServerIODispatch, later.
Gary
Re: Getters for DefaultHttpServerIODispatch
Posted by Gary Gregory <ga...@gmail.com>.
I just realized looking at my code that I am working with a pair
of DefaultHttpServerIODispatch and DefaultHttpClientIODispatch, so I will
apply the same changes to DefaultHttpClientIODispatch.
Gary
On Sat, Jan 6, 2018 at 11:11 AM, Gary Gregory <ga...@gmail.com>
wrote:
> On Sat, Jan 6, 2018 at 3:47 AM, Oleg Kalnichevski <ol...@apache.org>
> wrote:
>
>> On Fri, 2018-01-05 at 15:56 -0700, Gary Gregory wrote:
>> > Hi Oleg,
>> >
>> > Yes, subclassing affords all sorts of hacks/features and such. Can
>> > you
>> > please clarify: would you -1 adding these getters?
>> >
>> > Gary
>> >
>>
>> Hi Gary
>>
>> Of course, I will not. I am just wondering if really want to cut a new
>> release because of a single getter?
>>
>
> Hi Oleg,
>
> There are other small changes in there already toward a 4.4.9:
>
> * HTTPCORE-494: Add image constants to ContentType.
> * HTTPCORE-496: Add API org.apache.http.protocol.
> UriPatternMatcher.entrySet().
> * HTTPCORE-497: Add API org.apache.http.nio.protocol.
> UriHttpAsyncRequestHandlerMapper.getUriPatternMatcher().
> * HTTPCORE-499: Make interface Header extend NameValuePair
>
> I will proceed over the weekend with this change...
>
> Gary
>
>
>>
>> Oleg
>>
>>
>> > On Fri, Jan 5, 2018 at 3:17 PM, Oleg Kalnichevski <ol...@apache.org>
>> > wrote:
>> >
>> > > On Fri, 2018-01-05 at 15:15 -0700, Gary Gregory wrote:
>> > > > Hi Oleg,
>> > > >
>> > > > Not really, the ivars are private.
>> > > >
>> > >
>> > > Nothing stops you from adding an instance variable to the subclass,
>> > > does it not?
>> > >
>> > > Oleg
>> > >
>> > >
>> > > > Gary
>> > > >
>> > > > On Fri, Jan 5, 2018 at 3:12 PM, Oleg Kalnichevski <olegk@apache.o
>> > > > rg>
>> > > > wrote:
>> > > >
>> > > > > On Fri, 2018-01-05 at 14:10 -0700, Gary Gregory wrote:
>> > > > > > Hi All,
>> > > > > >
>> > > > > > Are there any objects to my adding getters for:
>> > > > > >
>> > > > > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.connFact
>> > > > > > ory
>> > > > > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.handler
>> > > > > >
>> > > > > > I need to get the handler I stick in a
>> > > > > > DefaultHttpServerIODispatch,
>> > > > > > later.
>> > > > > >
>> > > > > > Gary
>> > > > >
>> > > > > Hi Gary
>> > > > >
>> > > > > You can also just subclass DefaultHttpServerIODispatch and
>> > > > > provide
>> > > > > the
>> > > > > getter from the subclass.
>> > > > >
>> > > > > Oleg
>> > > > >
>> > > > > -------------------------------------------------------------
>> > > > > ----
>> > > > > ----
>> > > > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>> > > > > For additional commands, e-mail: dev-help@hc.apache.org
>> > > > >
>> > > > >
>> > >
>> > > -----------------------------------------------------------------
>> > > ----
>> > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>> > > For additional commands, e-mail: dev-help@hc.apache.org
>> > >
>> > >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>> For additional commands, e-mail: dev-help@hc.apache.org
>>
>>
>
Re: Getters for DefaultHttpServerIODispatch
Posted by Gary Gregory <ga...@gmail.com>.
On Sat, Jan 6, 2018 at 3:47 AM, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Fri, 2018-01-05 at 15:56 -0700, Gary Gregory wrote:
> > Hi Oleg,
> >
> > Yes, subclassing affords all sorts of hacks/features and such. Can
> > you
> > please clarify: would you -1 adding these getters?
> >
> > Gary
> >
>
> Hi Gary
>
> Of course, I will not. I am just wondering if really want to cut a new
> release because of a single getter?
>
Hi Oleg,
There are other small changes in there already toward a 4.4.9:
* HTTPCORE-494: Add image constants to ContentType.
* HTTPCORE-496: Add API
org.apache.http.protocol.UriPatternMatcher.entrySet().
* HTTPCORE-497: Add API
org.apache.http.nio.protocol.UriHttpAsyncRequestHandlerMapper.getUriPatternMatcher().
* HTTPCORE-499: Make interface Header extend NameValuePair
I will proceed over the weekend with this change...
Gary
>
> Oleg
>
>
> > On Fri, Jan 5, 2018 at 3:17 PM, Oleg Kalnichevski <ol...@apache.org>
> > wrote:
> >
> > > On Fri, 2018-01-05 at 15:15 -0700, Gary Gregory wrote:
> > > > Hi Oleg,
> > > >
> > > > Not really, the ivars are private.
> > > >
> > >
> > > Nothing stops you from adding an instance variable to the subclass,
> > > does it not?
> > >
> > > Oleg
> > >
> > >
> > > > Gary
> > > >
> > > > On Fri, Jan 5, 2018 at 3:12 PM, Oleg Kalnichevski <olegk@apache.o
> > > > rg>
> > > > wrote:
> > > >
> > > > > On Fri, 2018-01-05 at 14:10 -0700, Gary Gregory wrote:
> > > > > > Hi All,
> > > > > >
> > > > > > Are there any objects to my adding getters for:
> > > > > >
> > > > > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.connFact
> > > > > > ory
> > > > > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.handler
> > > > > >
> > > > > > I need to get the handler I stick in a
> > > > > > DefaultHttpServerIODispatch,
> > > > > > later.
> > > > > >
> > > > > > Gary
> > > > >
> > > > > Hi Gary
> > > > >
> > > > > You can also just subclass DefaultHttpServerIODispatch and
> > > > > provide
> > > > > the
> > > > > getter from the subclass.
> > > > >
> > > > > Oleg
> > > > >
> > > > > -------------------------------------------------------------
> > > > > ----
> > > > > ----
> > > > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > > > > For additional commands, e-mail: dev-help@hc.apache.org
> > > > >
> > > > >
> > >
> > > -----------------------------------------------------------------
> > > ----
> > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > > For additional commands, e-mail: dev-help@hc.apache.org
> > >
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Getters for DefaultHttpServerIODispatch
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, 2018-01-05 at 15:56 -0700, Gary Gregory wrote:
> Hi Oleg,
>
> Yes, subclassing affords all sorts of hacks/features and such. Can
> you
> please clarify: would you -1 adding these getters?
>
> Gary
>
Hi Gary
Of course, I will not. I am just wondering if really want to cut a new
release because of a single getter?
Oleg
> On Fri, Jan 5, 2018 at 3:17 PM, Oleg Kalnichevski <ol...@apache.org>
> wrote:
>
> > On Fri, 2018-01-05 at 15:15 -0700, Gary Gregory wrote:
> > > Hi Oleg,
> > >
> > > Not really, the ivars are private.
> > >
> >
> > Nothing stops you from adding an instance variable to the subclass,
> > does it not?
> >
> > Oleg
> >
> >
> > > Gary
> > >
> > > On Fri, Jan 5, 2018 at 3:12 PM, Oleg Kalnichevski <olegk@apache.o
> > > rg>
> > > wrote:
> > >
> > > > On Fri, 2018-01-05 at 14:10 -0700, Gary Gregory wrote:
> > > > > Hi All,
> > > > >
> > > > > Are there any objects to my adding getters for:
> > > > >
> > > > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.connFact
> > > > > ory
> > > > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.handler
> > > > >
> > > > > I need to get the handler I stick in a
> > > > > DefaultHttpServerIODispatch,
> > > > > later.
> > > > >
> > > > > Gary
> > > >
> > > > Hi Gary
> > > >
> > > > You can also just subclass DefaultHttpServerIODispatch and
> > > > provide
> > > > the
> > > > getter from the subclass.
> > > >
> > > > Oleg
> > > >
> > > > -------------------------------------------------------------
> > > > ----
> > > > ----
> > > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > > > For additional commands, e-mail: dev-help@hc.apache.org
> > > >
> > > >
> >
> > -----------------------------------------------------------------
> > ----
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Getters for DefaultHttpServerIODispatch
Posted by Gary Gregory <ga...@gmail.com>.
Hi Oleg,
Yes, subclassing affords all sorts of hacks/features and such. Can you
please clarify: would you -1 adding these getters?
Gary
On Fri, Jan 5, 2018 at 3:17 PM, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Fri, 2018-01-05 at 15:15 -0700, Gary Gregory wrote:
> > Hi Oleg,
> >
> > Not really, the ivars are private.
> >
>
> Nothing stops you from adding an instance variable to the subclass,
> does it not?
>
> Oleg
>
>
> > Gary
> >
> > On Fri, Jan 5, 2018 at 3:12 PM, Oleg Kalnichevski <ol...@apache.org>
> > wrote:
> >
> > > On Fri, 2018-01-05 at 14:10 -0700, Gary Gregory wrote:
> > > > Hi All,
> > > >
> > > > Are there any objects to my adding getters for:
> > > >
> > > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.connFactory
> > > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.handler
> > > >
> > > > I need to get the handler I stick in a
> > > > DefaultHttpServerIODispatch,
> > > > later.
> > > >
> > > > Gary
> > >
> > > Hi Gary
> > >
> > > You can also just subclass DefaultHttpServerIODispatch and provide
> > > the
> > > getter from the subclass.
> > >
> > > Oleg
> > >
> > > -----------------------------------------------------------------
> > > ----
> > > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > > For additional commands, e-mail: dev-help@hc.apache.org
> > >
> > >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Getters for DefaultHttpServerIODispatch
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, 2018-01-05 at 15:15 -0700, Gary Gregory wrote:
> Hi Oleg,
>
> Not really, the ivars are private.
>
Nothing stops you from adding an instance variable to the subclass,
does it not?
Oleg
> Gary
>
> On Fri, Jan 5, 2018 at 3:12 PM, Oleg Kalnichevski <ol...@apache.org>
> wrote:
>
> > On Fri, 2018-01-05 at 14:10 -0700, Gary Gregory wrote:
> > > Hi All,
> > >
> > > Are there any objects to my adding getters for:
> > >
> > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.connFactory
> > > org.apache.http.impl.nio.DefaultHttpServerIODispatch.handler
> > >
> > > I need to get the handler I stick in a
> > > DefaultHttpServerIODispatch,
> > > later.
> > >
> > > Gary
> >
> > Hi Gary
> >
> > You can also just subclass DefaultHttpServerIODispatch and provide
> > the
> > getter from the subclass.
> >
> > Oleg
> >
> > -----------------------------------------------------------------
> > ----
> > To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> > For additional commands, e-mail: dev-help@hc.apache.org
> >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
Re: Getters for DefaultHttpServerIODispatch
Posted by Gary Gregory <ga...@gmail.com>.
Hi Oleg,
Not really, the ivars are private.
Gary
On Fri, Jan 5, 2018 at 3:12 PM, Oleg Kalnichevski <ol...@apache.org> wrote:
> On Fri, 2018-01-05 at 14:10 -0700, Gary Gregory wrote:
> > Hi All,
> >
> > Are there any objects to my adding getters for:
> >
> > org.apache.http.impl.nio.DefaultHttpServerIODispatch.connFactory
> > org.apache.http.impl.nio.DefaultHttpServerIODispatch.handler
> >
> > I need to get the handler I stick in a DefaultHttpServerIODispatch,
> > later.
> >
> > Gary
>
> Hi Gary
>
> You can also just subclass DefaultHttpServerIODispatch and provide the
> getter from the subclass.
>
> Oleg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
>
>
Re: Getters for DefaultHttpServerIODispatch
Posted by Oleg Kalnichevski <ol...@apache.org>.
On Fri, 2018-01-05 at 14:10 -0700, Gary Gregory wrote:
> Hi All,
>
> Are there any objects to my adding getters for:
>
> org.apache.http.impl.nio.DefaultHttpServerIODispatch.connFactory
> org.apache.http.impl.nio.DefaultHttpServerIODispatch.handler
>
> I need to get the handler I stick in a DefaultHttpServerIODispatch,
> later.
>
> Gary
Hi Gary
You can also just subclass DefaultHttpServerIODispatch and provide the
getter from the subclass.
Oleg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org