You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by GitBox <gi...@apache.org> on 2020/03/27 18:58:37 UTC
[GitHub] [shiro] bmhm opened a new pull request #207: [SHIRO-750] update
jax-rs dependency to jakarta. Non-Breaking change.
bmhm opened a new pull request #207: [SHIRO-750] update jax-rs dependency to jakarta. Non-Breaking change.
URL: https://github.com/apache/shiro/pull/207
Please discuss whether or not this is a breaking change.
From my perspective it is not, feel free to prove me wrong :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shiro] bmhm commented on issue #207: [SHIRO-750] update jax-rs
dependency to jakarta. Non-Breaking change.
Posted by GitBox <gi...@apache.org>.
bmhm commented on issue #207: [SHIRO-750] update jax-rs dependency to jakarta. Non-Breaking change.
URL: https://github.com/apache/shiro/pull/207#issuecomment-605225607
Travis build log:
https://travis-ci.com/github/bmhm/shiro/builds/155929411
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shiro] bmhm commented on a change in pull request #207:
[SHIRO-750] update jax-rs dependency to jakarta. Non-Breaking change.
Posted by GitBox <gi...@apache.org>.
bmhm commented on a change in pull request #207: [SHIRO-750] update jax-rs dependency to jakarta. Non-Breaking change.
URL: https://github.com/apache/shiro/pull/207#discussion_r399646963
##########
File path: support/jaxrs/pom.xml
##########
@@ -45,8 +45,8 @@
</dependency>
<dependency>
- <groupId>javax.ws.rs</groupId>
- <artifactId>javax.ws.rs-api</artifactId>
+ <groupId>jakarta.ws.rs</groupId>
+ <artifactId>jakarta.ws.rs-api</artifactId>
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shiro] bdemers commented on a change in pull request #207:
[SHIRO-750] update jax-rs dependency to jakarta. Non-Breaking change.
Posted by GitBox <gi...@apache.org>.
bdemers commented on a change in pull request #207: [SHIRO-750] update jax-rs dependency to jakarta. Non-Breaking change.
URL: https://github.com/apache/shiro/pull/207#discussion_r399488499
##########
File path: support/jaxrs/pom.xml
##########
@@ -45,8 +45,8 @@
</dependency>
<dependency>
- <groupId>javax.ws.rs</groupId>
- <artifactId>javax.ws.rs-api</artifactId>
+ <groupId>jakarta.ws.rs</groupId>
+ <artifactId>jakarta.ws.rs-api</artifactId>
Review comment:
set the scope to `provided` and we should be good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services