You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/01/06 12:21:55 UTC
Re: Review Request 41855: Trace pending executors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 7:21 p.m.)
Review request for mesos and Guangya Liu.
Changes
-------
Correct comments
Summary (updated)
-----------------
Trace pending executors
Bugs: MESOS-3982
https://issues.apache.org/jira/browse/MESOS-3982
Repository: mesos
Description
-------
Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
Diffs (updated)
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41855/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41855: Trace pending executors.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/#review113614
-----------------------------------------------------------
src/slave/slave.hpp (line 803)
<https://reviews.apache.org/r/41855/#comment174378>
The comments above is "// Current running executors." but pendingExecutors does not fit into this comments.
- Guangya Liu
On 一月 9, 2016, 9:38 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41855/
> -----------------------------------------------------------
>
> (Updated 一月 9, 2016, 9:38 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41855/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41855: Trace pending executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
-----------------------------------------------------------
(Updated March 11, 2016, 2:17 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
Rebase
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
Diffs (updated)
-----
src/slave/slave.hpp 7520cc356e2b1b7f5fff15f33071a46a7b05e762
src/slave/slave.cpp 840534ff0687e82ed063c386e36bbabada230697
Diff: https://reviews.apache.org/r/41855/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41855: Trace pending executors.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/#review115534
-----------------------------------------------------------
src/slave/slave.cpp (lines 1384 - 1388)
<https://reviews.apache.org/r/41855/#comment176509>
You probably don't need this additional tracking.
It looks like you're inserting the executor eviction logic inside the code path for running executors. i.e.:
`::runTask` -> (evict executors logic) ->
`::_runTask` -> `::launchExecutor`
All of these things happen inside the Agent actor and the eviction logic can be mostly synchronous. So you can just pass the executor-to-be-launched around.
(The less state you save == less error prone the function is.)
- Joseph Wu
On Jan. 9, 2016, 1:38 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41855/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 1:38 a.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41855/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41855: Trace pending executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
-----------------------------------------------------------
(Updated Jan. 9, 2016, 5:38 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
Address comments
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
Diffs (updated)
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41855/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41855: Trace pending executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/#review113435
-----------------------------------------------------------
src/slave/slave.cpp (line 1379)
<https://reviews.apache.org/r/41855/#comment174083>
If the executors exist, did not add it into pendingExecutors list. Will update diff after dependencies rebased.
- Klaus Ma
On Jan. 8, 2016, 2:53 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41855/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 2:53 p.m.)
>
>
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
>
>
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
> src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
>
> Diff: https://reviews.apache.org/r/41855/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 41855: Trace pending executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
-----------------------------------------------------------
(Updated Jan. 8, 2016, 2:53 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Summary (updated)
-----------------
Trace pending executors.
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41855/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41855: WIP: Trace pending executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 8:34 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Summary (updated)
-----------------
WIP: Trace pending executors.
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41855/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41855: [WIP] Trace pending executors.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
-----------------------------------------------------------
(Updated Jan. 7, 2016, 8:05 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Summary (updated)
-----------------
[WIP] Trace pending executors.
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41855/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41855: [WIP] Trace pending executors
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 10:03 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
rebase
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
Diffs (updated)
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f
Diff: https://reviews.apache.org/r/41855/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41855: [WIP] Trace pending executors
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 8:48 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
Working rebase
Summary (updated)
-----------------
[WIP] Trace pending executors
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
Diffs (updated)
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41855/diff/
Testing
-------
Thanks,
Klaus Ma
Re: Review Request 41855: Trace pending executors
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
-----------------------------------------------------------
(Updated Jan. 6, 2016, 7:24 p.m.)
Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, and Jian Qiu.
Changes
-------
Correct defect # and add reviewers.
Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892
Repository: mesos
Description
-------
Trace the executor that are not launched; after launching, it's removed from pendingExecutor list.
Diffs
-----
src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c
src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c
Diff: https://reviews.apache.org/r/41855/diff/
Testing
-------
Thanks,
Klaus Ma