You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by du...@apache.org on 2022/07/31 06:47:20 UTC
[rocketmq-schema-registry] 33/34: update method name and desc
This is an automated email from the ASF dual-hosted git repository.
duhengforever pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/rocketmq-schema-registry.git
commit fd1f190099c0165839254bedaad869f0eba9c9f7
Author: fan <wa...@xiaomi.com>
AuthorDate: Sun Jul 31 14:28:39 2022 +0800
update method name and desc
---
.../rocketmq/schema/registry/common/dto/DeleteSchemeResponse.java | 2 +-
.../{GetSchemaBySubjectResponse.java => GetSchemaResponse.java} | 4 ++--
.../rocketmq/schema/registry/core/api/v1/SchemaController.java | 8 ++++----
.../rocketmq/schema/registry/core/service/SchemaService.java | 4 ++--
.../rocketmq/schema/registry/core/service/SchemaServiceImpl.java | 6 +++---
5 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/DeleteSchemeResponse.java b/common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/DeleteSchemeResponse.java
index 7418958..1a2e723 100644
--- a/common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/DeleteSchemeResponse.java
+++ b/common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/DeleteSchemeResponse.java
@@ -35,7 +35,7 @@ public class DeleteSchemeResponse extends BaseDto {
@ApiModelProperty(value = "Deleted schema id")
private long schemaId;
- @ApiModelProperty(value = "Deleted schema id")
+ @ApiModelProperty(value = "Deleted schema version")
private long version;
}
diff --git a/common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/GetSchemaBySubjectResponse.java b/common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/GetSchemaResponse.java
similarity index 93%
rename from common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/GetSchemaBySubjectResponse.java
rename to common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/GetSchemaResponse.java
index e70a02c..5853f46 100644
--- a/common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/GetSchemaBySubjectResponse.java
+++ b/common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/GetSchemaResponse.java
@@ -34,7 +34,7 @@ import lombok.NoArgsConstructor;
@Builder
@NoArgsConstructor
@AllArgsConstructor
-public class GetSchemaBySubjectResponse extends BaseDto {
+public class GetSchemaResponse extends BaseDto {
private static final long serialVersionUID = -4612593696179069203L;
@ApiModelProperty(value = "Schema dependency")
@@ -58,7 +58,7 @@ public class GetSchemaBySubjectResponse extends BaseDto {
@ApiModelProperty(value = "Schema type")
private SchemaType type;
- public GetSchemaBySubjectResponse(QualifiedName name, SchemaRecordInfo schemaRecordInfo) {
+ public GetSchemaResponse(QualifiedName name, SchemaRecordInfo schemaRecordInfo) {
this.subjectFullName = name.subjectFullName();
this.schemaId = schemaRecordInfo.getSchemaId();
this.version = schemaRecordInfo.getVersion();
diff --git a/core/src/main/java/org/apache/rocketmq/schema/registry/core/api/v1/SchemaController.java b/core/src/main/java/org/apache/rocketmq/schema/registry/core/api/v1/SchemaController.java
index 96bdd5a..c04fcf7 100644
--- a/core/src/main/java/org/apache/rocketmq/schema/registry/core/api/v1/SchemaController.java
+++ b/core/src/main/java/org/apache/rocketmq/schema/registry/core/api/v1/SchemaController.java
@@ -27,7 +27,7 @@ import java.util.List;
import lombok.extern.slf4j.Slf4j;
import org.apache.rocketmq.schema.registry.common.QualifiedName;
import org.apache.rocketmq.schema.registry.common.dto.DeleteSchemeResponse;
-import org.apache.rocketmq.schema.registry.common.dto.GetSchemaBySubjectResponse;
+import org.apache.rocketmq.schema.registry.common.dto.GetSchemaResponse;
import org.apache.rocketmq.schema.registry.common.dto.RegisterSchemaRequest;
import org.apache.rocketmq.schema.registry.common.dto.RegisterSchemaResponse;
import org.apache.rocketmq.schema.registry.common.dto.SchemaDto;
@@ -331,7 +331,7 @@ public class SchemaController {
)
}
)
- public GetSchemaBySubjectResponse getSchemaBySubject(
+ public GetSchemaResponse getSchemaBySubject(
@ApiParam(value = "The name of the subject", required = true)
@PathVariable(value = "subject-name") String subject
) {
@@ -357,7 +357,7 @@ public class SchemaController {
)
}
)
- public GetSchemaBySubjectResponse getSchemaBySubject(
+ public GetSchemaResponse getSchemaBySubject(
@ApiParam(value = "The cluster of the subject", required = true)
@PathVariable(value = "cluster-name") final String cluster,
@ApiParam(value = "The tenant of the schema", required = true)
@@ -393,7 +393,7 @@ public class SchemaController {
)
}
)
- public GetSchemaBySubjectResponse getSchemaBySubject(
+ public GetSchemaResponse getSchemaBySubject(
@ApiParam(value = "The cluster of the subject", required = true)
@PathVariable(value = "cluster-name") final String cluster,
@ApiParam(value = "The tenant of the schema", required = true)
diff --git a/core/src/main/java/org/apache/rocketmq/schema/registry/core/service/SchemaService.java b/core/src/main/java/org/apache/rocketmq/schema/registry/core/service/SchemaService.java
index a21ae54..2d67437 100644
--- a/core/src/main/java/org/apache/rocketmq/schema/registry/core/service/SchemaService.java
+++ b/core/src/main/java/org/apache/rocketmq/schema/registry/core/service/SchemaService.java
@@ -21,7 +21,7 @@ import java.util.List;
import org.apache.rocketmq.schema.registry.common.QualifiedName;
import org.apache.rocketmq.schema.registry.common.dto.BaseDto;
import org.apache.rocketmq.schema.registry.common.dto.DeleteSchemeResponse;
-import org.apache.rocketmq.schema.registry.common.dto.GetSchemaBySubjectResponse;
+import org.apache.rocketmq.schema.registry.common.dto.GetSchemaResponse;
import org.apache.rocketmq.schema.registry.common.dto.RegisterSchemaRequest;
import org.apache.rocketmq.schema.registry.common.dto.RegisterSchemaResponse;
import org.apache.rocketmq.schema.registry.common.dto.SchemaRecordDto;
@@ -70,7 +70,7 @@ public interface SchemaService<T extends BaseDto> {
* @param qualifiedName subject of the schema binding
* @return schema object with the schemaName
*/
- GetSchemaBySubjectResponse getBySubject(QualifiedName qualifiedName);
+ GetSchemaResponse getBySubject(QualifiedName qualifiedName);
/**
* Query the schema object with the given subject name.
diff --git a/core/src/main/java/org/apache/rocketmq/schema/registry/core/service/SchemaServiceImpl.java b/core/src/main/java/org/apache/rocketmq/schema/registry/core/service/SchemaServiceImpl.java
index b8c62dd..95f02fd 100644
--- a/core/src/main/java/org/apache/rocketmq/schema/registry/core/service/SchemaServiceImpl.java
+++ b/core/src/main/java/org/apache/rocketmq/schema/registry/core/service/SchemaServiceImpl.java
@@ -27,7 +27,7 @@ import org.apache.rocketmq.schema.registry.common.auth.AccessControlService;
import org.apache.rocketmq.schema.registry.common.context.RequestContext;
import org.apache.rocketmq.schema.registry.common.context.RequestContextManager;
import org.apache.rocketmq.schema.registry.common.dto.DeleteSchemeResponse;
-import org.apache.rocketmq.schema.registry.common.dto.GetSchemaBySubjectResponse;
+import org.apache.rocketmq.schema.registry.common.dto.GetSchemaResponse;
import org.apache.rocketmq.schema.registry.common.dto.RegisterSchemaRequest;
import org.apache.rocketmq.schema.registry.common.dto.RegisterSchemaResponse;
import org.apache.rocketmq.schema.registry.common.dto.SchemaDto;
@@ -233,7 +233,7 @@ public class SchemaServiceImpl implements SchemaService<SchemaDto> {
* {@inheritDoc}
*/
@Override
- public GetSchemaBySubjectResponse getBySubject(QualifiedName qualifiedName) {
+ public GetSchemaResponse getBySubject(QualifiedName qualifiedName) {
final RequestContext requestContext = RequestContextManager.getContext();
log.info("register get request context: " + requestContext);
@@ -245,7 +245,7 @@ public class SchemaServiceImpl implements SchemaService<SchemaDto> {
}
log.info("get schema by subject: {}", qualifiedName.getSubject());
- return new GetSchemaBySubjectResponse(qualifiedName, recordInfo);
+ return new GetSchemaResponse(qualifiedName, recordInfo);
}
@Override