You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/23 23:31:38 UTC
[GitHub] [netbeans] Caffe1neAdd1ct opened a new pull request #2103: [NETBEANS-3972] Draft implementation of GIT GPG signing
Caffe1neAdd1ct opened a new pull request #2103:
URL: https://github.com/apache/netbeans/pull/2103
Initial draft of GIT GPG commit signing, I'm not happy with this implementation and need some guidance on how to improve this implementation.
1. Alteration of the commit() command construct signature breaks a lot of tests and doesn't feel like the right way to pass through the GPG passphrase to jgit/bouncycastle.
2. GPG Passphrase popup doesn't obfuscate the input and isn't a great UX being separate and before the commit window for file selection/author/committer etc
3. Override checkbox on the commit window to enable/disable signing like author/committer would also be useful.
I've built this on the 11.3 stable release of netbeans but will follow guidance on how to raise a new pull request as needed. To build/run at the moment all tests in Git and Git Client Library need disabling for now due to the commit command construct change.
I'm happy to continue attempting to implement this, but Java isn't my primary language (so please go easy).
Calling for suggestions and guidance on implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #2103: [NETBEANS-3972] Draft implementation of GIT GPG signing
Posted by GitBox <gi...@apache.org>.
ebarboni commented on pull request #2103:
URL: https://github.com/apache/netbeans/pull/2103#issuecomment-621930386
@Caffe1neAdd1ct, please have discussion on dev list to find some help. I have no idea how to help here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists