[GitHub] matthiasblaesing commented on issue #916: [NETBEANS-1074] Module review j2ee.dd

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #916: [NETBEANS-1074] Module review j2ee.dd
URL: https://github.com/apache/incubator-netbeans/pull/916#issuecomment-435165063
 
 
   Thanks for the update. I have two remaining issues:
   
   - the licenses of the javaee-api-5.jar is not ALv2 (see the `META-INF/LICENSE.TXT` inf the file)
   - the two license file `glassfish-license.txt` and `w3c-license.txt` don't belong into the `external` directory, as the corresponding files were removed. The run of `ant -Dcluster.config=enterprise verify-libs-and-licenses` should report that (the travis-ci runs currently only cover a subset of the codebase).
   
   I also added a `.gitignore` to the module directory, so that the generated files from the XSDs are not reported as "new" files for git.
   
   I squashed your commits into one and added the changes described above as a second commit:
   https://github.com/matthiasblaesing/incubator-netbeans/commits/github-pr-916
   
   The update:
   https://github.com/matthiasblaesing/incubator-netbeans/commit/f1c806ff5cdad04f2a16dd518d474ca1cc03919e
   
   It would be great if you could have a look. If you agree, I would squash these two commits together, leave you as the author and merge that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists