You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2022/01/28 22:44:43 UTC

[Impala-ASF-CR] IMPALA-11095: Impala-shell strict hs2 mode insert fails.

Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18176


Change subject: IMPALA-11095: Impala-shell strict_hs2 mode insert fails.
......................................................................

IMPALA-11095: Impala-shell strict_hs2 mode insert fails.

The insert command was broken for impala-shell in the strict_hs2
mode. The return parameter for close_dml should return two parameters.

The parameters returned by close_dml are rows returned and error
rows. These are not supported by strict hs2 mode since the close
does not return the TDmlResult structure. So the message to
the end user also had to be changed.

Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
---
M shell/impala_client.py
M shell/impala_shell.py
M tests/shell/test_shell_commandline.py
3 files changed, 14 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/18176/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>

[Impala-ASF-CR] IMPALA-11095: Impala-shell strict hs2 mode insert fails.

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Impala-shell strict_hs2 mode insert fails.
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 31 Jan 2022 12:19:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Fix Impala-shell strict hs2 mode inserts

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Fix Impala-shell strict_hs2 mode inserts
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 01:08:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Impala-shell strict hs2 mode insert fails.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Impala-shell strict_hs2 mode insert fails.
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10066/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jan 2022 23:08:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Fix Impala-shell strict hs2 mode inserts

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Fix Impala-shell strict_hs2 mode inserts
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10084/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 02:21:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Fix Impala-shell strict hs2 mode inserts

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Fix Impala-shell strict_hs2 mode inserts
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7793/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 03 Feb 2022 18:36:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Fix Impala-shell strict hs2 mode inserts

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Fix Impala-shell strict_hs2 mode inserts
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 4
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 07:42:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Fix Impala-shell strict hs2 mode inserts

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Fix Impala-shell strict_hs2 mode inserts
......................................................................

IMPALA-11095: Fix Impala-shell strict_hs2 mode inserts

The insert command was broken for impala-shell in the strict_hs2
mode. The return parameter for close_dml should return two parameters.

The parameters returned by close_dml are rows returned and error
rows. These are not supported by strict hs2 mode since the close
does not return the TDmlResult structure. So the message to
the end user also had to be changed.

Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Reviewed-on: http://gerrit.cloudera.org:8080/18176
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M shell/impala_client.py
M shell/impala_shell.py
M tests/shell/test_shell_commandline.py
3 files changed, 14 insertions(+), 8 deletions(-)

Approvals:
  Impala Public Jenkins: Verified
  Csaba Ringhofer: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11095: Impala-shell strict hs2 mode insert fails.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Impala-shell strict_hs2 mode insert fails.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18176/1/shell/impala_shell.py
File shell/impala_shell.py:

http://gerrit.cloudera.org:8080/#/c/18176/1/shell/impala_shell.py@1329
PS1, Line 1329: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/18176/1/shell/impala_shell.py@1332
PS1, Line 1332: \
flake8: E502 the backslash is redundant between brackets



-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jan 2022 22:45:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-11095: Impala-shell strict hs2 mode insert fails.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Impala-shell strict_hs2 mode insert fails.
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7773/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jan 2022 23:45:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Impala-shell strict hs2 mode insert fails.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Impala-shell strict_hs2 mode insert fails.
......................................................................


Patch Set 2:

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7785/


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 00:12:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Impala-shell strict hs2 mode insert fails.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Impala-shell strict_hs2 mode insert fails.
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7773/


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 29 Jan 2022 06:13:42 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Fix Impala-shell strict hs2 mode inserts

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18176

to look at the new patch set (#3).

Change subject: IMPALA-11095: Fix Impala-shell strict_hs2 mode inserts
......................................................................

IMPALA-11095: Fix Impala-shell strict_hs2 mode inserts

The insert command was broken for impala-shell in the strict_hs2
mode. The return parameter for close_dml should return two parameters.

The parameters returned by close_dml are rows returned and error
rows. These are not supported by strict hs2 mode since the close
does not return the TDmlResult structure. So the message to
the end user also had to be changed.

Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
---
M shell/impala_client.py
M shell/impala_shell.py
M tests/shell/test_shell_commandline.py
3 files changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/18176/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11095: Impala-shell strict hs2 mode insert fails.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Impala-shell strict_hs2 mode insert fails.
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7785/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 17:40:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Fix Impala-shell strict hs2 mode inserts

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Fix Impala-shell strict_hs2 mode inserts
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 12:48:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Impala-shell strict hs2 mode insert fails.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18176 )

Change subject: IMPALA-11095: Impala-shell strict_hs2 mode insert fails.
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/10068/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jan 2022 23:27:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11095: Impala-shell strict hs2 mode insert fails.

Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18176

to look at the new patch set (#2).

Change subject: IMPALA-11095: Impala-shell strict_hs2 mode insert fails.
......................................................................

IMPALA-11095: Impala-shell strict_hs2 mode insert fails.

The insert command was broken for impala-shell in the strict_hs2
mode. The return parameter for close_dml should return two parameters.

The parameters returned by close_dml are rows returned and error
rows. These are not supported by strict hs2 mode since the close
does not return the TDmlResult structure. So the message to
the end user also had to be changed.

Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
---
M shell/impala_client.py
M shell/impala_shell.py
M tests/shell/test_shell_commandline.py
3 files changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/18176/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18176
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibe837c99e54d68d1e27b97f0025e17faf0a2cb9f
Gerrit-Change-Number: 18176
Gerrit-PatchSet: 2
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>