You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@yetus.apache.org by GitBox <gi...@apache.org> on 2020/03/30 08:58:23 UTC
[GitHub] [yetus] aajisaka opened a new pull request #101: YETUS-959. Dead
links in precommit-advanced
aajisaka opened a new pull request #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101
JIRA: https://issues.apache.org/jira/browse/YETUS-959
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] apache-yetus commented on issue #101: YETUS-959. Dead links
in precommit-advanced
Posted by GitBox <gi...@apache.org>.
apache-yetus commented on issue #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101#issuecomment-608102854
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 39s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | markdownlint | 0m 0s | There were no new markdownlint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. |
| | | 2m 6s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-101/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/yetus/pull/101 |
| Optional Tests | dupname asflicense markdownlint |
| uname | Linux c320e7bb5c8e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / 24aae05 |
| Max. process+thread count | 46 (vs. ulimit of 2000) |
| modules | C: asf-site-src U: asf-site-src |
| Console output | https://builds.apache.org/job/yetus-github-multibranch/job/PR-101/3/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 |
| Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] apache-yetus commented on issue #101: YETUS-959. Dead links
in precommit-advanced
Posted by GitBox <gi...@apache.org>.
apache-yetus commented on issue #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101#issuecomment-606388865
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 42s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | markdownlint | 0m 2s | There were no new markdownlint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. |
| | | 2m 8s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-101/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/yetus/pull/101 |
| Optional Tests | dupname asflicense markdownlint |
| uname | Linux ff39c3a8c236 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / c88ea1a |
| Max. process+thread count | 46 (vs. ulimit of 2000) |
| modules | C: asf-site-src U: asf-site-src |
| Console output | https://builds.apache.org/job/yetus-github-multibranch/job/PR-101/2/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 |
| Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] ndimiduk commented on a change in pull request #101:
YETUS-959. Dead links in precommit-advanced
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101#discussion_r401012855
##########
File path: asf-site-src/source/documentation/in-progress/precommit-advanced.html.md
##########
@@ -196,7 +196,7 @@ The `add_test` function is used to activate the standard tests. Additional plug
## Module & Profile Determination
-Once the tests are determined, it is now time to pick which [modules](precommit-glossary.md#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
+Once the tests are determined, it is now time to pick which [modules](../precommit-glossary#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
Review comment:
Oh, disregard that last query. The link is designed to be browsed from https://yetus.apache.org/contribute/website/, not from the source repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] aajisaka merged pull request #101: YETUS-959. Dead links in
precommit-advanced
Posted by GitBox <gi...@apache.org>.
aajisaka merged pull request #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] aw-was-here commented on a change in pull request #101:
YETUS-959. Dead links in precommit-advanced
Posted by GitBox <gi...@apache.org>.
aw-was-here commented on a change in pull request #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101#discussion_r401000009
##########
File path: asf-site-src/source/documentation/in-progress/precommit-advanced.html.md
##########
@@ -196,7 +196,7 @@ The `add_test` function is used to activate the standard tests. Additional plug
## Module & Profile Determination
-Once the tests are determined, it is now time to pick which [modules](precommit-glossary.md#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
+Once the tests are determined, it is now time to pick which [modules](../precommit-glossary#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
Review comment:
It's configured correctly. It makes links and URLs effectively directories instead of files for a cleaner look when users pass things around.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] ndimiduk commented on a change in pull request #101:
YETUS-959. Dead links in precommit-advanced
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101#discussion_r400327877
##########
File path: asf-site-src/source/documentation/in-progress/precommit-advanced.html.md
##########
@@ -196,7 +196,7 @@ The `add_test` function is used to activate the standard tests. Additional plug
## Module & Profile Determination
-Once the tests are determined, it is now time to pick which [modules](precommit-glossary.md#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
+Once the tests are determined, it is now time to pick which [modules](../precommit-glossary#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
Review comment:
Why the `..` ? These paths look correct to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] aajisaka commented on issue #101: YETUS-959. Dead links in
precommit-advanced
Posted by GitBox <gi...@apache.org>.
aajisaka commented on issue #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101#issuecomment-608539638
Merged. Thanks @ndimiduk and @aw-was-here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] apache-yetus commented on issue #101: YETUS-959. Dead links
in precommit-advanced
Posted by GitBox <gi...@apache.org>.
apache-yetus commented on issue #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101#issuecomment-605891921
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 44s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | markdownlint | 0m 0s | There were no new markdownlint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. |
| | | 2m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/yetus-github-multibranch/job/PR-101/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/yetus/pull/101 |
| Optional Tests | dupname asflicense markdownlint |
| uname | Linux 07ffe7e9e181 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | precommit/src/main/shell/personality/yetus.sh |
| git revision | master / 0615de8 |
| Max. process+thread count | 46 (vs. ulimit of 2000) |
| modules | C: asf-site-src U: asf-site-src |
| Console output | https://builds.apache.org/job/yetus-github-multibranch/job/PR-101/1/console |
| versions | git=2.7.4 maven=3.3.9 markdownlint=0.22.0 |
| Powered by | Apache Yetus 0.12.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] ndimiduk commented on a change in pull request #101:
YETUS-959. Dead links in precommit-advanced
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101#discussion_r401011896
##########
File path: asf-site-src/source/documentation/in-progress/precommit-advanced.html.md
##########
@@ -196,7 +196,7 @@ The `add_test` function is used to activate the standard tests. Additional plug
## Module & Profile Determination
-Once the tests are determined, it is now time to pick which [modules](precommit-glossary.md#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
+Once the tests are determined, it is now time to pick which [modules](../precommit-glossary#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
Review comment:
Okay, so the links here are incorrect according to the overall site configuration. Thanks for explaining. You guys have a link to where site generation happens? I see we have a branch `asf-site`, but the link from https://github.com/apache/yetus/blob/master/asf-site-src/source/contribute.html.md to "Maintaining the Yetus Website" is also dead. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] ndimiduk commented on a change in pull request #101:
YETUS-959. Dead links in precommit-advanced
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on a change in pull request #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101#discussion_r400500322
##########
File path: asf-site-src/source/documentation/in-progress/precommit-advanced.html.md
##########
@@ -196,7 +196,7 @@ The `add_test` function is used to activate the standard tests. Additional plug
## Module & Profile Determination
-Once the tests are determined, it is now time to pick which [modules](precommit-glossary.md#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
+Once the tests are determined, it is now time to pick which [modules](../precommit-glossary#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
Review comment:
Seems odd. Maybe it's better to configure the static site generator properly instead? I'm not familiar with how this is built.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [yetus] aajisaka commented on a change in pull request #101:
YETUS-959. Dead links in precommit-advanced
Posted by GitBox <gi...@apache.org>.
aajisaka commented on a change in pull request #101: YETUS-959. Dead links in precommit-advanced
URL: https://github.com/apache/yetus/pull/101#discussion_r400354061
##########
File path: asf-site-src/source/documentation/in-progress/precommit-advanced.html.md
##########
@@ -196,7 +196,7 @@ The `add_test` function is used to activate the standard tests. Additional plug
## Module & Profile Determination
-Once the tests are determined, it is now time to pick which [modules](precommit-glossary.md#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
+Once the tests are determined, it is now time to pick which [modules](../precommit-glossary#genericoutside-definitions) should get used. That's the job of the `personality_modules` function.
Review comment:
The path is not correct in the generated docs. For example, in Yetus 0.11.1, the link is "https://yetus.apache.org/documentation/0.11.1/precommit-advanced/precommit-glossary.md#genericoutside-definitions" and I want to change it to "https://yetus.apache.org/documentation/0.11.1/precommit-glossary#genericoutside-definitions". That's why `..` is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services