[jira] [Commented] (FLINK-6275) Unprotected access to resourceManager in YarnFlinkApplicationMasterRunner#runApplicationMaster

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994732#comment-15994732 ] 

ASF GitHub Bot commented on FLINK-6275:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3724
  
    I think this should be done differently. The access to the resourceManager should be under the lock, but not the waiting on the termination future. Otherwise the lock is held too long.


> Unprotected access to resourceManager in YarnFlinkApplicationMasterRunner#runApplicationMaster
> ----------------------------------------------------------------------------------------------
>
>                 Key: FLINK-6275
>                 URL: https://issues.apache.org/jira/browse/FLINK-6275
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: mingleizhang
>            Priority: Minor
>
> {code}
>       // wait for resource manager to finish
>       resourceManager.getTerminationFuture().get();
> {code}
> The above is outside synchronized block.
> @GuardedBy indicates that access should be protected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)