You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/08/15 17:28:37 UTC

[GitHub] [sling-maven-plugin] kwin opened a new pull request, #16: SLING-11543 improve exception handling for invalid bundle files

kwin opened a new pull request, #16:
URL: https://github.com/apache/sling-maven-plugin/pull/16

   add ITs for standalone goal usage of "install" and "install-file"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-maven-plugin] sonarcloud[bot] commented on pull request #16: SLING-11543 improve exception handling for invalid bundle files

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #16:
URL: https://github.com/apache/sling-maven-plugin/pull/16#issuecomment-1215467099

   Kudos, SonarCloud Quality Gate passed!&nbsp; &nbsp; [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Quality Gate passed')](https://sonarcloud.io/dashboard?id=apache_sling-maven-plugin&pullRequest=16)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-maven-plugin&pullRequest=16&resolved=false&types=CODE_SMELL)
   
   [![33.3%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/25-16px.png '33.3%')](https://sonarcloud.io/component_measures?id=apache_sling-maven-plugin&pullRequest=16&metric=new_coverage&view=list) [33.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-maven-plugin&pullRequest=16&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_sling-maven-plugin&pullRequest=16&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-maven-plugin&pullRequest=16&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-maven-plugin] stefanseifert commented on a diff in pull request #16: SLING-11543 improve exception handling for invalid bundle files

Posted by GitBox <gi...@apache.org>.
stefanseifert commented on code in PR #16:
URL: https://github.com/apache/sling-maven-plugin/pull/16#discussion_r946686737


##########
src/main/java/org/apache/sling/maven/bundlesupport/BundleInstallMojo.java:
##########
@@ -65,7 +65,7 @@ protected File getBundleFileName() {
                 getLog().debug("No bundle found in secondary artifact " + file);
             }
         }
-        return null;
+        throw new MojoExecutionException("No attached bundle found for this Maven project, for standalone usage use goal 'install-file' instead!");

Review Comment:
   with this explicit error message it's fine in my pov.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-maven-plugin] kwin commented on a diff in pull request #16: SLING-11543 improve exception handling for invalid bundle files

Posted by GitBox <gi...@apache.org>.
kwin commented on code in PR #16:
URL: https://github.com/apache/sling-maven-plugin/pull/16#discussion_r945986084


##########
src/main/java/org/apache/sling/maven/bundlesupport/BundleInstallMojo.java:
##########
@@ -65,7 +65,7 @@ protected File getBundleFileName() {
                 getLog().debug("No bundle found in secondary artifact " + file);
             }
         }
-        return null;
+        throw new MojoExecutionException("No attached bundle found for this Maven project, for standalone usage use goal 'install-file' instead!");

Review Comment:
   Not sure if we need to more more lenient for backwards-compatibility reasons. OTOH calling this goal should either succeed or fail the build in case the bundle cannot be installed for whatever reason (this is crucial particularly for non-interactive e.g. CI builds where no one is checking the logs). Just silently (i.e. with just some log message) skipping is bad behaviour for a Maven plugin.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sling-maven-plugin] kwin merged pull request #16: SLING-11543 improve exception handling for invalid bundle files

Posted by GitBox <gi...@apache.org>.
kwin merged PR #16:
URL: https://github.com/apache/sling-maven-plugin/pull/16


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org