You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/27 12:02:57 UTC

[GitHub] [apisix] spacewander commented on a change in pull request #6428: ci: add shellcheck linter

spacewander commented on a change in pull request #6428:
URL: https://github.com/apache/apisix/pull/6428#discussion_r815429692



##########
File path: ci/common.sh
##########
@@ -15,6 +15,8 @@
 # limitations under the License.
 #
 
+# shellcheck disable=SC2148

Review comment:
       I think it is quite strange to add a warning and disable it later. Let's remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org