You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Phil Scala <sc...@gmail.com> on 2016/01/16 20:49:57 UTC

Re: Review Request 34649: Configurable poll delay for spooling directory source

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34649/#review114873
-----------------------------------------------------------



flume-ng-doc/sphinx/FlumeUserGuide.rst (line 965)
<https://reviews.apache.org/r/34649/#comment175709>

    Minor comment with the text, looks like there is a missing space after the word "Delay" and before the "("


- Phil Scala


On May 25, 2015, 12:07 p.m., Somin Mithraa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34649/
> -----------------------------------------------------------
> 
> (Updated May 25, 2015, 12:07 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> SpoolDir source polls a directory for new files at specific interval. This interval(or poll delay) is currently hardcoded as 500ms. 500ms may be too fast for some applications. This patch is to make this property configurable.
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java d0c2e99 
>   flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySourceConfigurationConstants.java 895433e 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 718c879 
> 
> Diff: https://reviews.apache.org/r/34649/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done to confirm poll delay is set from the configuration file.
> 
> 
> Thanks,
> 
> Somin Mithraa
> 
>