[GitHub] [hudi] zhedoubushishi commented on a change in pull request #1876: [HUDI-242] Support for RFC-12/Bootstrapping of external datasets

[GitBox <gi...@apache.org>]

zhedoubushishi commented on a change in pull request #1876:
URL: https://github.com/apache/hudi/pull/1876#discussion_r464620123



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/deltastreamer/HoodieDeltaStreamer.java
##########
@@ -627,6 +672,128 @@ private HoodieInstant fetchNextCompactionInstant() throws InterruptedException {
   }
 
   public DeltaSyncService getDeltaSyncService() {
-    return deltaSyncService;
+    return deltaSyncService.get();
+  }
+
+  /**
+   * Performs bootstrap from a non-hudi source.
+   */
+  public static class BootstrapExecutor  implements Serializable {

Review comment:
       Do you think it's better to relocate this class as a separate class? Like [HDFSParquetImporter](https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/HDFSParquetImporter.java), [HoodieCompactor](https://github.com/apache/hudi/blob/master/hudi-utilities/src/main/java/org/apache/hudi/utilities/HoodieCompactor.java)?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org