[GitHub] [druid] maytasm commented on pull request #11424: Supervisor metadata auto cleanup failing as missing Guice injection

[GitBox <gi...@apache.org>]

maytasm commented on pull request #11424:
URL: https://github.com/apache/druid/pull/11424#issuecomment-877635280


   @clintropolis @abhishekagarwal87 Sorry to bother you both but I had to make some changes to the PR. Turns out that I cannot bind TaskStorage in CliCoordinator. This is because when we run the Coordinator together with the Overlord, then both CliCoordinator and CliOverlord will both try to bind TaskStorage, resulting in Guice error. I found out that you can annotate using the @Nullable to tell Guice to bind null if the binding is not given. 
   
   Hence, removed `binder.bind(TaskStorage.class).toProvider(Providers.of(null));` in CliCoordinator and added @Nullable  to the constructor of the different SupervisorSpecs.  


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org