You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/26 11:40:16 UTC
[GitHub] [spark] MaxGekk opened a new pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
MaxGekk opened a new pull request #31972:
URL: https://github.com/apache/spark/pull/31972
### What changes were proposed in this pull request?
1. Add new expression `DivideDTInterval` which multiplies a `DayTimeIntervalType` expression by a `NumericType` expression including ByteType, ShortType, IntegerType, LongType, FloatType, DoubleType, DecimalType.
2. Extend binary arithmetic rules to support `day-time interval / numeric`.
### Why are the changes needed?
To conform the ANSI SQL standard which requires such operation over day-time intervals:
<img width="656" alt="Screenshot 2021-03-25 at 18 44 58" src="https://user-images.githubusercontent.com/1580697/112501559-68f07080-8d9a-11eb-8781-66e6631bb7ef.png">
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running new tests:
```
$ build/sbt "test:testOnly *IntervalExpressionsSuite"
$ build/sbt "test:testOnly *ColumnExpressionSuite"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31972:
URL: https://github.com/apache/spark/pull/31972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808174819
**[Test build #136566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136566/testReport)** for PR 31972 at commit [`33db142`](https://github.com/apache/spark/commit/33db1427e3941eeab95a1232bd7d546be7ed1d85).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808362712
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41150/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808362649
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41150/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808392478
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136566/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808174819
**[Test build #136566 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136566/testReport)** for PR 31972 at commit [`33db142`](https://github.com/apache/spark/commit/33db1427e3941eeab95a1232bd7d546be7ed1d85).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] MaxGekk commented on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808271181
@cloud-fan @yaooqinn Could you review this PR, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808316269
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808362712
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/41150/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808392478
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/136566/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808385212
**[Test build #136566 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/136566/testReport)** for PR 31972 at commit [`33db142`](https://github.com/apache/spark/commit/33db1427e3941eeab95a1232bd7d546be7ed1d85).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31972: [SPARK-34875][SQL] Support divide a day-time interval by a numeric
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31972:
URL: https://github.com/apache/spark/pull/31972#issuecomment-808306915
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/41150/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org