You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2017/10/09 23:11:27 UTC

[GitHub] spark pull request #18853: [SPARK-21646][SQL] CommonType for binary comparis...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18853#discussion_r143598538
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala ---
    @@ -412,7 +480,66 @@ object TypeCoercion {
     
             val commonTypes = lhs.zip(rhs).flatMap { case (l, r) =>
               findCommonTypeForBinaryComparison(l.dataType, r.dataType)
    +              .orElse(findTightestCommonType(l.dataType, r.dataType))
    --- End diff --
    
    Could you still try to avoid duplicating the codes?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org