You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "tirkarthi (via GitHub)" <gi...@apache.org> on 2023/07/08 16:19:48 UTC

[GitHub] [airflow] tirkarthi opened a new issue, #32442: Dag run timeout with timedelta value is rendered as [object object] in UI

tirkarthi opened a new issue, #32442:
URL: https://github.com/apache/airflow/issues/32442

   ### Apache Airflow version
   
   main (development)
   
   ### What happened
   
   Dag run timeout with timedelta value is rendered as [object object] in UI. It seems the data is fetched and string is used to render the value. timedelta is handled for schedule_interval which should also be done here.
   
   ![image](https://github.com/apache/airflow/assets/3972343/0a1e2257-4e7c-49a2-bde8-e9a796146cc5)
   
   
   ### What you think should happen instead
   
   timedelta should be handled similar to how it's done in scheduleInterval value here.
   
   https://github.com/apache/airflow/blob/e70bee00cd12ecf1462485a747c0e3296ef7d48c/airflow/www/static/js/dag/details/Dag.tsx#L278C2-L293
   
   ### How to reproduce
   
   1. Create a dag with dag_run_timeout as timedelta value.
   2. Visit the dag details tab in grid view to check dag_run_timeout
   
   ### Operating System
   
   Ubuntu
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Virtualenv installation
   
   ### Deployment details
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] sanjurm16 commented on issue #32442: Dag run timeout with timedelta value is rendered as [object object] in UI

Posted by "sanjurm16 (via GitHub)" <gi...@apache.org>.
sanjurm16 commented on issue #32442:
URL: https://github.com/apache/airflow/issues/32442#issuecomment-1632984122

   @potiuk I have raised a PR. Please review and share your feedback if any. Let me know if you need any evidences or screenshot post fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] sanjurm16 commented on issue #32442: Dag run timeout with timedelta value is rendered as [object object] in UI

Posted by "sanjurm16 (via GitHub)" <gi...@apache.org>.
sanjurm16 commented on issue #32442:
URL: https://github.com/apache/airflow/issues/32442#issuecomment-1627529008

   cheers!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #32442: Dag run timeout with timedelta value is rendered as [object object] in UI

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #32442:
URL: https://github.com/apache/airflow/issues/32442#issuecomment-1627528794

   feel free


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] sanjurm16 commented on issue #32442: Dag run timeout with timedelta value is rendered as [object object] in UI

Posted by "sanjurm16 (via GitHub)" <gi...@apache.org>.
sanjurm16 commented on issue #32442:
URL: https://github.com/apache/airflow/issues/32442#issuecomment-1627527987

   Hello, can I pick this up?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi closed issue #32442: Dag run timeout with timedelta value is rendered as [object object] in UI

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi closed issue #32442: Dag run timeout with timedelta value is rendered as [object object] in UI
URL: https://github.com/apache/airflow/issues/32442


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org