You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/01/20 18:36:36 UTC

[GitHub] [beam] Abacn opened a new pull request, #25102: [Release-2.45.0] Cherry pick: Fix truncate copy job when WRITE_TRUNCATE

Abacn opened a new pull request, #25102:
URL: https://github.com/apache/beam/pull/25102

   ... in BigQuery batch load
   
   cherry-pick #25101 into release-2.45.0 
   justification: this is a bug fix of data loss; the original fix, aibeit a typo prevented it took effect, was in 2.45.0.
   
   **Please** add a meaningful description for your change here
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on pull request #25102: [Release-2.45.0] Cherry pick: Fix truncate copy job when WRITE_TRUNCATE

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #25102:
URL: https://github.com/apache/beam/pull/25102#issuecomment-1398820308

   Run Whitespace PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #25102: [Release-2.45.0] Cherry pick: Fix truncate copy job when WRITE_TRUNCATE

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #25102:
URL: https://github.com/apache/beam/pull/25102#issuecomment-1398830272

   btw white space is expected to fail on release branch; the fix is #25055 not in release-2.45.0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] Abacn commented on pull request #25102: [Release-2.45.0] Cherry pick: Fix truncate copy job when WRITE_TRUNCATE

Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #25102:
URL: https://github.com/apache/beam/pull/25102#issuecomment-1398787145

   R: @johnjcasey 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on pull request #25102: [Release-2.45.0] Cherry pick: Fix truncate copy job when WRITE_TRUNCATE

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #25102:
URL: https://github.com/apache/beam/pull/25102#issuecomment-1398825380

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey commented on pull request #25102: [Release-2.45.0] Cherry pick: Fix truncate copy job when WRITE_TRUNCATE

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #25102:
URL: https://github.com/apache/beam/pull/25102#issuecomment-1398820092

   Run Spotless PreCommit


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] johnjcasey merged pull request #25102: [Release-2.45.0] Cherry pick: Fix truncate copy job when WRITE_TRUNCATE

Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey merged PR #25102:
URL: https://github.com/apache/beam/pull/25102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org