You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "nkeywal (Created) (JIRA)" <ji...@apache.org> on 2011/12/16 09:36:30 UTC
[jira] [Created] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
----------------------------------------------------------------------------------
Key: HBASE-5051
URL: https://issues.apache.org/jira/browse/HBASE-5051
Project: HBase
Issue Type: Bug
Components: test
Affects Versions: 0.94.0
Reporter: nkeywal
Assignee: nkeywal
Priority: Minor
As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Attachment: 5051.v2.patch
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173024#comment-13173024 ]
Hudson commented on HBASE-5051:
-------------------------------
Integrated in HBase-TRUNK-security #38 (See [https://builds.apache.org/job/HBase-TRUNK-security/38/])
HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Attachment: 5051.v2.patch
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171231#comment-13171231 ]
Zhihong Yu commented on HBASE-5051:
-----------------------------------
TestMasterRestartAfterDisablingTable.testForCheckingIfEnableAndDisableWorksFineAfterSwitch failure in TRUNK can be reproduced on MacBook.
Strangely TestMasterRestartAfterDisablingTable didn't appear in the patch.
Could be related to the changes in HMaster.java
Reverting the patch until we determine the root cause.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Status: Patch Available (was: Open)
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172561#comment-13172561 ]
Hudson commented on HBASE-5051:
-------------------------------
Integrated in HBase-TRUNK #2559 (See [https://builds.apache.org/job/HBase-TRUNK/2559/])
HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterRestartAfterDisablingTable.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171035#comment-13171035 ]
nkeywal commented on HBASE-5051:
--------------------------------
TestMasterRestartAfterDisablingTable.testForCheckingIfEnableAndDisableWorksFineAfterSwitch = "Too many open files"
TestReplication.queueFailover = usual flaky test, works locally (just rechecked)
TestInstantSchemaChange.testInstantSchemaJanitor = "Too many open files"
TestInstantSchemaChange.testInstantSchemaChangeBlocksDuringLoadBalancerRun = "Too many open files"
patch ok imho.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Status: Open (was: Patch Available)
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172263#comment-13172263 ]
nkeywal commented on HBASE-5051:
--------------------------------
TestMasterReplication hang; but it hang on trunk as well (see: https://builds.apache.org/job/HBase-TRUNK/2558/console)
TestReplication: usually flaky.
I think the patch is ok.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171235#comment-13171235 ]
Zhihong Yu commented on HBASE-5051:
-----------------------------------
I should have double checked: I don't see 'Too many open files' here:
https://builds.apache.org/job/PreCommit-HBASE-Build/521//testReport/org.apache.hadoop.hbase.master/TestMasterRestartAfterDisablingTable/testForCheckingIfEnableAndDisableWorksFineAfterSwitch/
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Attachment: 5051.patch
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5051:
-------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks for the patch N.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171285#comment-13171285 ]
Zhihong Yu commented on HBASE-5051:
-----------------------------------
Yeah. TestMasterRestartAfterDisablingTable passes now.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Status: Open (was: Patch Available)
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171155#comment-13171155 ]
Hudson commented on HBASE-5051:
-------------------------------
Integrated in HBase-TRUNK-security #34 (See [https://builds.apache.org/job/HBase-TRUNK-security/34/])
HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call (N Keywal)
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171506#comment-13171506 ]
Hadoop QA commented on HBASE-5051:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507771/5051.v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -152 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestInstantSchemaChange
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/530//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/530//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/530//console
This message is automatically generated.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Status: Patch Available (was: Open)
retrying with the same patch
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171256#comment-13171256 ]
nkeywal commented on HBASE-5051:
--------------------------------
my error. sorry. will look after this.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171014#comment-13171014 ]
Hadoop QA commented on HBASE-5051:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507670/5051.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 36 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -152 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
org.apache.hadoop.hbase.replication.TestReplication
org.apache.hadoop.hbase.client.TestInstantSchemaChange
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/521//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/521//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/521//console
This message is automatically generated.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171112#comment-13171112 ]
Zhihong Yu commented on HBASE-5051:
-----------------------------------
Integrated to TRUNK.
Thanks for the patch, N.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Status: Open (was: Patch Available)
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171372#comment-13171372 ]
Hudson commented on HBASE-5051:
-------------------------------
Integrated in HBase-TRUNK #2552 (See [https://builds.apache.org/job/HBase-TRUNK/2552/])
HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call - revert
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Status: Patch Available (was: Open)
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172175#comment-13172175 ]
Hadoop QA commented on HBASE-5051:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507880/5051.v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -152 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplication
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/543//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/543//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/543//console
This message is automatically generated.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Status: Patch Available (was: Open)
This should do it.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Attachment: 5051.v2.patch
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171484#comment-13171484 ]
Hudson commented on HBASE-5051:
-------------------------------
Integrated in HBase-TRUNK-security #35 (See [https://builds.apache.org/job/HBase-TRUNK-security/35/])
HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call - revert
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171562#comment-13171562 ]
Hadoop QA commented on HBASE-5051:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507776/5051.v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -152 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.client.TestInstantSchemaChange
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/531//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/531//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/531//console
This message is automatically generated.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171522#comment-13171522 ]
nkeywal commented on HBASE-5051:
--------------------------------
mapred.TestTableMapReduce.testMultiRegionTable: NumberFormatException: For input string: "18446743988037478956"
mapreduce.TestHFileOutputFormat.testMRIncrementalLoad: NumberFormatException: For input string: "18446743988037169444"
mapreduce.TestHFileOutputFormat.testMRIncrementalLoadWithSplit NumberFormatException: For input string: "18446743988037182259"
mapreduce.TestHFileOutputFormat.testExcludeMinorCompaction: NumberFormatException: For input string: "18446743988037186552"
TestReplication.queueFailover: ??
TestInstantSchemaChange.testInstantSchemaJanitor: Too many open files
TestMasterReplication: hung
TestMasterReplication works locally. The patch should not have impacted it. It hungs on trunk as well (see: https://builds.apache.org/job/HBase-TRUNK/2553/testReport/org.apache.hadoop.hbase.replication/ : there is no entry for TestMasterReplication)
TestReplication works locally. This test is usually flaky.
mapred.TestTableMapReduce worked in the previous prebuild.
mapreduce.TestHFileOutputFormat worked in the previous prebuild.
Let's retry.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Attachment: 5051.v2.patch
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171216#comment-13171216 ]
Hudson commented on HBASE-5051:
-------------------------------
Integrated in HBase-TRUNK #2550 (See [https://builds.apache.org/job/HBase-TRUNK/2550/])
HBASE-5051 HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call (N Keywal)
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/constraint/TestConstraint.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerBulkLoad.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollAbort.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestScannersWithFilters.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/rest/TestTableResource.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/hbck/OfflineMetaRebuildTestCore.java
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Status: Patch Available (was: Open)
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171338#comment-13171338 ]
Zhihong Yu commented on HBASE-5051:
-----------------------------------
TestMasterReplication hung in the above build.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171329#comment-13171329 ]
Hadoop QA commented on HBASE-5051:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12507739/5051.v2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 39 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -152 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 76 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/527//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/527//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/527//console
This message is automatically generated.
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5051) HBaseTestingUtility#getHBaseAdmin()
creates a new HBaseAdmin instance at each call
Posted by "nkeywal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
nkeywal updated HBASE-5051:
---------------------------
Status: Open (was: Patch Available)
> HBaseTestingUtility#getHBaseAdmin() creates a new HBaseAdmin instance at each call
> ----------------------------------------------------------------------------------
>
> Key: HBASE-5051
> URL: https://issues.apache.org/jira/browse/HBASE-5051
> Project: HBase
> Issue Type: Bug
> Components: test
> Affects Versions: 0.94.0
> Reporter: nkeywal
> Assignee: nkeywal
> Priority: Minor
> Attachments: 5051.patch, 5051.v2.patch
>
>
> As it's a new instance, it should be closed. As the function name seems to imply that it's an instance managed by HBaseTestingUtility, most of the users don't close it => leak
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira