You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2012/10/12 00:51:03 UTC

[jira] [Commented] (HBASE-6979) recovered.edits file should not break distributed log splitting

    [ https://issues.apache.org/jira/browse/HBASE-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474582#comment-13474582 ] 

stack commented on HBASE-6979:
------------------------------

Why we have a file and folder named recovered.edits (We used to have a file named recovered.edits but so we could handle the case where a regionserver has multiple edits to replay, we made a folder named recovered.edits into which we put the files to replay).  In tests there should not be any file named recovered.edits.  Is the test making these?

That said, the patch is good.  Is there a better place than /tmp to move the file?  If we delete it, it'll go into hadoop trash?  Should stick around a while in there?  Would that be good enough?
                
> recovered.edits file should not break distributed log splitting
> ---------------------------------------------------------------
>
>                 Key: HBASE-6979
>                 URL: https://issues.apache.org/jira/browse/HBASE-6979
>             Project: HBase
>          Issue Type: Improvement
>          Components: master
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: trunk-6979.patch
>
>
> Distributed log splitting fails in creating the recovered.edits folder during upgrade because there is a file called recovered.edits there.
> Instead of checking if the patch exists, we need to check if it exists and is a path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira