[GitHub] [incubator-superset] betodealmeida commented on issue #8213: Better distinction between tables and views, and show CREATE VIEW

[GitBox <gi...@apache.org>]

betodealmeida commented on issue #8213: Better distinction between tables and views, and show CREATE VIEW
URL: https://github.com/apache/incubator-superset/pull/8213#issuecomment-530528321
 
 
   > This is a nice feature. However, it seems to be unnecessarily specific to Presto, and should be fairly easy to enable for other engines, too, by moving as much of the logic as possible to BaseEngineSpec raising NotImplementedError() if not enabled (the Presto spec is getting fairly heavy lately, and there's probably other stuff that could be made more generic to benefit other engines). Probably ok to keep this in Presto for now, and I can probably work on making this accessible to other engines in a later PR.
   
   I agree. I think we need to start by adding an abstract method to `BaseEngineSpec` for running queries, and then it should be trivial to extend this to other engines. I'll create a ticket and give it a try when I have some bandwidth.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org