You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/05/28 20:40:12 UTC
Review Request 34777: Perf: Skip calling hostVersionDAO by
HostComponentResourceProvider if host_version isn't requested
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34777/
-----------------------------------------------------------
Review request for Ambari and Myroslav Papirkovskyy.
Bugs: AMBARI-11498
https://issues.apache.org/jira/browse/AMBARI-11498
Repository: ambari
Description
-------
20% of server resources are spent for execution hostVersionDAO.findByHostAndStateCurrent() , added check if host version requested, if no - no need to execute DB query.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 818147b
ambari-server/src/main/resources/META-INF/persistence.xml 4b30c0c
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f6898e9
Diff: https://reviews.apache.org/r/34777/diff/
Testing
-------
unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 34777: Perf: Skip calling hostVersionDAO by
HostComponentResourceProvider if host_version isn't requested
Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34777/#review85594
-----------------------------------------------------------
Ship it!
Ship It!
- Myroslav Papirkovskyy
On Травень 28, 2015, 9:40 після полудня, Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34777/
> -----------------------------------------------------------
>
> (Updated Травень 28, 2015, 9:40 після полудня)
>
>
> Review request for Ambari and Myroslav Papirkovskyy.
>
>
> Bugs: AMBARI-11498
> https://issues.apache.org/jira/browse/AMBARI-11498
>
>
> Repository: ambari
>
>
> Description
> -------
>
> 20% of server resources are spent for execution hostVersionDAO.findByHostAndStateCurrent() , added check if host version requested, if no - no need to execute DB query.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java 818147b
> ambari-server/src/main/resources/META-INF/persistence.xml 4b30c0c
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/HostComponentResourceProviderTest.java f6898e9
>
> Diff: https://reviews.apache.org/r/34777/diff/
>
>
> Testing
> -------
>
> unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>