You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "zmuxuny (via GitHub)" <gi...@apache.org> on 2026/09/23 08:09:45 UTC
[PR] [studio] fix(ci): build frontend image with runner Docker [rocketmq-dashboard]
zmuxuny opened a new pull request, #5020:
URL: https://github.com/apache/rocketmq-dashboard/pull/5020
### Which Issue(s) This PR Fixes
- Fixes #4136
- Depends on #5019 for the frontend image's existing license-gate failure.
### Brief Description
Every recent `CI` pull-request run ends in `startup_failure` before creating any job. The workflow references `docker/setup-buildx-action` and `docker/build-push-action`, which are not on the Apache organization action allowlist described in #4136. Replace those steps with the runner's built-in `docker build` command. The frontend image's Dockerfile does not require Buildx features.
This is a workflow-only change; it restores execution of all build and test jobs. PR #5019 separately fixes the frontend build failure that becomes visible once the Docker job can run.
### How Did You Test This Change?
- Parsed `.github/workflows/ci.yml` with PyYAML and ran `git diff --check`.
- Ran the exact `docker build -t rocketmq-studio-web:ci ./web` build command locally. On the current base it reaches the frontend build and fails at the pre-existing license gate; with the fix from #5019, the image builds successfully.
- Confirmed recent upstream CI runs are `startup_failure` before any jobs execute, including run `35834435086` from 2026-09-23.
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits
- [x] No source files or UI text changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [studio] fix(ci): pin Docker actions to Apache-approved SHAs [rocketmq-dashboard]
Posted by "zmuxuny (via GitHub)" <gi...@apache.org>.
zmuxuny commented on PR #5020:
URL: https://github.com/apache/rocketmq-dashboard/pull/5020#issuecomment-5806097805
@lizhimins Could you please review #5020 when you have time? The current workflow still ends in `startup_failure` before creating any jobs on PRs from multiple contributors (for example, [this run on #5060](https://github.com/apache/rocketmq-dashboard/actions/runs/35908452558) and [another contributor's run](https://github.com/apache/rocketmq-dashboard/actions/runs/35911236217)). In contrast, [the run on #5020](https://github.com/apache/rocketmq-dashboard/actions/runs/35838525708) created all five jobs and reached the Docker build. Its remaining job failures are separate from workflow startup and are documented in the PR.
This uses published-tag SHA pins and addresses the concern you raised on #2550. Would this approach be acceptable for fixing the startup blocker? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [studio] fix(ci): pin Docker actions to Apache-approved SHAs [rocketmq-dashboard]
Posted by "zmuxuny (via GitHub)" <gi...@apache.org>.
zmuxuny commented on PR #5020:
URL: https://github.com/apache/rocketmq-dashboard/pull/5020#issuecomment-5911403662
@lizhimins Following up on the September 24 review request. The workflow startup blocker is still affecting new contributions: [the September 30 run on #5202](https://github.com/apache/rocketmq-dashboard/actions/runs/36680842944) failed before creating jobs because the Docker action tag references are not allowed by the ASF policy.
[The run on this PR](https://github.com/apache/rocketmq-dashboard/actions/runs/35838525708) got past that restriction and started all five jobs. The subsequent test and license-check failures remain separate; this PR is limited to unblocking workflow startup.
Could you confirm whether the SHA-pinning approach is acceptable, or what changes are needed before this can be reviewed and merged? If someone else is already handling the startup fix, please point me to that work so I can avoid duplication. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [studio] fix(ci): pin Docker actions to Apache-approved SHAs [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #5020:
URL: https://github.com/apache/rocketmq-dashboard/pull/5020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org