You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/02 12:16:57 UTC
[GitHub] [superset] geido opened a new pull request #16022: fix: Select the right section when categories and tags have the same name in Viz Gallery
geido opened a new pull request #16022:
URL: https://github.com/apache/superset/pull/16022
### SUMMARY
This PR fixes an issue that was causing the Viz Gallery to select the category-related viz types when a tag with the same category name was selected.
Fixes: #16012
### BEFORE
https://user-images.githubusercontent.com/60598000/127860476-b066f95e-f617-48f4-9aba-ef4ae9a6f349.mp4
### AFTER
https://user-images.githubusercontent.com/60598000/127860005-c3aed9a0-6c07-4603-b5fc-671d556dd2f4.mp4
### TESTING INSTRUCTIONS
1. Open the Viz Gallery, look for Treemap and see 'Distribution' in the Treemap tags
2. Click #Distribution on the left selection menu and look for Treemap
3. Click 'Distribution' under category on the left selection menu and look for Treemap
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [x] Has associated issue: #16012
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #16022: fix: Select the right section when categories and tags have the same name in Viz Gallery
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #16022:
URL: https://github.com/apache/superset/pull/16022#discussion_r680959214
##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl/VizTypeGallery.tsx
##########
@@ -52,6 +52,13 @@ type VizEntry = {
value: ChartMetadata;
};
+enum SECTIONS {
+ ALL_CHARTS = 'ALL_CHARTS',
+ CATEGORY = 'CATEGORY',
+ TAGS = 'TAGS',
+ RECOMMENDED_TAGS = 'RECOMMENDED_TAGS',
+}
Review comment:
nit: I believe the convention is to use Pascal case for enums: https://www.typescriptlang.org/docs/handbook/enums.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16022: fix: Select the right section when categories and tags have the same name in Viz Gallery
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16022:
URL: https://github.com/apache/superset/pull/16022#issuecomment-890991827
# [Codecov](https://codecov.io/gh/apache/superset/pull/16022?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16022](https://codecov.io/gh/apache/superset/pull/16022?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4f7fc4) into [master](https://codecov.io/gh/apache/superset/commit/a786373fffe1a5dc5e2419505f982b14dcc09305?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a786373) will **increase** coverage by `0.01%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/superset/pull/16022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16022 +/- ##
==========================================
+ Coverage 77.04% 77.05% +0.01%
==========================================
Files 990 990
Lines 52458 52492 +34
Branches 6637 6653 +16
==========================================
+ Hits 40416 40449 +33
Misses 11818 11818
- Partials 224 225 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.54% <90.47%> (+0.03%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16022?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ponents/controls/VizTypeControl/VizTypeGallery.tsx](https://codecov.io/gh/apache/superset/pull/16022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9WaXpUeXBlQ29udHJvbC9WaXpUeXBlR2FsbGVyeS50c3g=) | `94.83% <90.47%> (-1.41%)` | :arrow_down: |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/16022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `74.15% <0.00%> (+0.69%)` | :arrow_up: |
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16022/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `74.42% <0.00%> (+1.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16022?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16022?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a786373...b4f7fc4](https://codecov.io/gh/apache/superset/pull/16022?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian merged pull request #16022: fix: Select the right section when categories and tags have the same name in Viz Gallery
Posted by GitBox <gi...@apache.org>.
suddjian merged pull request #16022:
URL: https://github.com/apache/superset/pull/16022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16022: fix: Select the right section when categories and tags have the same name in Viz Gallery
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16022:
URL: https://github.com/apache/superset/pull/16022#issuecomment-891164373
@geido Ephemeral environment spinning up at http://52.11.44.24:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #16022: fix: Select the right section when categories and tags have the same name in Viz Gallery
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16022:
URL: https://github.com/apache/superset/pull/16022#issuecomment-891266856
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #16022: fix: Select the right section when categories and tags have the same name in Viz Gallery
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #16022:
URL: https://github.com/apache/superset/pull/16022#issuecomment-891072561
thanks for the fix! when things slow down, I will go through all the Tags, Descriptions and Categories again to make sure they make sense, and are optimized for search. sorry for the trouble 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16022: fix: Select the right section when categories and tags have the same name in Viz Gallery
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16022:
URL: https://github.com/apache/superset/pull/16022#issuecomment-890980092
@rosemarie-chiu @jinghua-qa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #16022: fix: Select the right section when categories and tags have the same name in Viz Gallery
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #16022:
URL: https://github.com/apache/superset/pull/16022#issuecomment-891133127
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org