[PR] Replace logic for determining whether a Tablet is in use [accumulo]

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion opened a new pull request, #3920:
URL: https://github.com/apache/accumulo/pull/3920

   The previous logic used the ingest and scan rates and would say a Tablet was not in use when the rates were zero. However, due to a smoothing function on the Rate class, this may not happen or would take a really long time. The logic was modified to use the internal Tablet activeScans and writesInProgress variables to determine if activity was currently happening instead of using the Rate-based metrics.
   
   Fixes #3907


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace logic for determining whether a Tablet is in use [accumulo]

["dlmarion (via GitHub)" <gi...@apache.org>]

dlmarion merged PR #3920:
URL: https://github.com/apache/accumulo/pull/3920


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Replace logic for determining whether a Tablet is in use [accumulo]

["keith-turner (via GitHub)" <gi...@apache.org>]

keith-turner commented on code in PR #3920:
URL: https://github.com/apache/accumulo/pull/3920#discussion_r1380350925


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##########
@@ -1597,4 +1597,12 @@ public void setLastAccessTime() {
     this.lastAccessTime = System.nanoTime();
   }
 
+  public boolean isInUse() {

Review Comment:
   The activeScan set is a hashset and writesInProgress is not volatile.  To go with the rest of the tablet code, need to sync to ensure getting latest data.
   
   ```suggestion
     public synchronized boolean isInUse() {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org