You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2018/07/31 17:55:26 UTC
[kudu-CR] [Java] Upgrade Dependencies
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11090
Change subject: [Java] Upgrade Dependencies
......................................................................
[Java] Upgrade Dependencies
Upgrades the Java dependencies and Gradle versions.
Also fixes a an issue in the dependencyUpdates plugin
where Scala milestone releases were being included.
Maintenance version upgrades:
- Mockito 2.19.0 -> 2.21.0
Gradle upgrades:
- Gradle 4.8.1 -> 4.9
- gradle-animalsniffer-plugin 1.4.3 -> 1.4.5
- gradle-errorprone-plugin 0.0.14 -> 0.0.16
- protobuf-gradle-plugin 0.8.5 -> 0.8.6
Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
M java/pom.xml
6 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/11090/1
--
To view, visit http://gerrit.cloudera.org:8080/11090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
Gerrit-Change-Number: 11090
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [Java] Upgrade Dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: [Java] Upgrade Dependencies
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
Gerrit-Change-Number: 11090
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [Java] Upgrade Dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11090 )
Change subject: [Java] Upgrade Dependencies
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
Gerrit-Change-Number: 11090
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 31 Jul 2018 21:16:20 +0000
Gerrit-HasComments: No
[kudu-CR] [Java] Upgrade Dependencies
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11090 )
Change subject: [Java] Upgrade Dependencies
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11090/2/java/gradle/quality.gradle
File java/gradle/quality.gradle:
http://gerrit.cloudera.org:8080/#/c/11090/2/java/gradle/quality.gradle@124
PS2, Line 124: .
> We weren't matching things like below because I wasn't expecting more chara
gotcha, thanks
--
To view, visit http://gerrit.cloudera.org:8080/11090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
Gerrit-Change-Number: 11090
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 31 Jul 2018 22:24:09 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Upgrade Dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11090 )
Change subject: [Java] Upgrade Dependencies
......................................................................
[Java] Upgrade Dependencies
Upgrades the Java dependencies and Gradle versions.
Also fixes an issue in the dependencyUpdates plugin
where Scala milestone releases were being included.
Maintenance version upgrades:
- Mockito 2.19.0 -> 2.21.0
Gradle upgrades:
- Gradle 4.8.1 -> 4.9
- gradle-animalsniffer-plugin 1.4.3 -> 1.4.5
- gradle-errorprone-plugin 0.0.14 -> 0.0.16
- protobuf-gradle-plugin 0.8.5 -> 0.8.6
Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
Reviewed-on: http://gerrit.cloudera.org:8080/11090
Tested-by: Grant Henke <gr...@apache.org>
Reviewed-by: Mike Percy <mp...@apache.org>
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
M java/pom.xml
6 files changed, 9 insertions(+), 9 deletions(-)
Approvals:
Grant Henke: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/11090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
Gerrit-Change-Number: 11090
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] [Java] Upgrade Dependencies
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/11090 )
Change subject: [Java] Upgrade Dependencies
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11090/2/java/gradle/quality.gradle
File java/gradle/quality.gradle:
http://gerrit.cloudera.org:8080/#/c/11090/2/java/gradle/quality.gradle@124
PS2, Line 124: .
why?
--
To view, visit http://gerrit.cloudera.org:8080/11090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
Gerrit-Change-Number: 11090
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 31 Jul 2018 22:14:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Upgrade Dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11090 )
Change subject: [Java] Upgrade Dependencies
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11090/2/java/gradle/quality.gradle
File java/gradle/quality.gradle:
http://gerrit.cloudera.org:8080/#/c/11090/2/java/gradle/quality.gradle@124
PS2, Line 124: .
> why?
We weren't matching things like below because I wasn't expecting more characters after the qualifier.
`org.scala-lang:scala-library [2.11.12 -> 2.13.0-M4-pre-20d3c21]`
--
To view, visit http://gerrit.cloudera.org:8080/11090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
Gerrit-Change-Number: 11090
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 31 Jul 2018 22:16:45 +0000
Gerrit-HasComments: Yes
[kudu-CR] [Java] Upgrade Dependencies
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11090 )
Change subject: [Java] Upgrade Dependencies
......................................................................
[Java] Upgrade Dependencies
Upgrades the Java dependencies and Gradle versions.
Also fixes an issue in the dependencyUpdates plugin
where Scala milestone releases were being included.
Maintenance version upgrades:
- Mockito 2.19.0 -> 2.21.0
Gradle upgrades:
- Gradle 4.8.1 -> 4.9
- gradle-animalsniffer-plugin 1.4.3 -> 1.4.5
- gradle-errorprone-plugin 0.0.14 -> 0.0.16
- protobuf-gradle-plugin 0.8.5 -> 0.8.6
Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
---
M java/buildSrc/build.gradle
M java/gradle/dependencies.gradle
M java/gradle/quality.gradle
M java/gradle/wrapper/gradle-wrapper.properties
M java/gradlew
M java/pom.xml
6 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/90/11090/2
--
To view, visit http://gerrit.cloudera.org:8080/11090
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79c4d5917d13ed18d9df6ba5ef704e4f0081936d
Gerrit-Change-Number: 11090
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>