[GitHub] [iceberg] kbendick commented on a change in pull request #4152: enable stream-results option to avoid spark driver oom

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #4152:
URL: https://github.com/apache/iceberg/pull/4152#discussion_r809683627



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java
##########
@@ -102,6 +104,10 @@ public StructType outputType() {
         action.executeDeleteWith(executorService(maxConcurrentDeletes, "expire-snapshots"));
       }
 
+      if (streamResult) {
+        action.option("stream-results", streamResult.toString());

Review comment:
       Would it be possible / desirable to just pass `streamResults` as is (either true or false), to avoid the conditional check? It should be an accepted option for the action either way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org