You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by fa...@apache.org on 2022/07/19 09:29:34 UTC

[incubator-seatunnel] branch dev updated: add unknown exception message (#2204)

This is an automated email from the ASF dual-hosted git repository.

fanjia pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-seatunnel.git


The following commit(s) were added to refs/heads/dev by this push:
     new 9baed6027 add unknown exception message (#2204)
9baed6027 is described below

commit 9baed60278d766d1a39507c8d056d233301be7b4
Author: Kerwin <37...@users.noreply.github.com>
AuthorDate: Tue Jul 19 17:29:29 2022 +0800

    add unknown exception message (#2204)
---
 .../main/java/org/apache/seatunnel/app/common/SeatunnelErrorEnum.java | 2 +-
 .../java/org/apache/seatunnel/app/util/GlobalExceptionHandler.java    | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/common/SeatunnelErrorEnum.java b/seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/common/SeatunnelErrorEnum.java
index 3f770b725..5e54ef5fa 100644
--- a/seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/common/SeatunnelErrorEnum.java
+++ b/seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/common/SeatunnelErrorEnum.java
@@ -24,7 +24,7 @@ public enum SeatunnelErrorEnum {
     USER_ALREADY_EXISTS(10003, "user already exist", "The same username [%s] is exist."),
     NO_SUCH_USER(10002, "no such user", "No such user. Maybe deleted by others."),
     ILLEGAL_STATE(99998, "illegal state", "%s"),
-    UNKNOWN(99999, "unknown exception", "unknown exception")
+    UNKNOWN(99999, "unknown exception", "%s")
     ;
 
     private final int code;
diff --git a/seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/util/GlobalExceptionHandler.java b/seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/util/GlobalExceptionHandler.java
index 3b3678c30..511dbe597 100644
--- a/seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/util/GlobalExceptionHandler.java
+++ b/seatunnel-server/seatunnel-app/src/main/java/org/apache/seatunnel/app/util/GlobalExceptionHandler.java
@@ -52,11 +52,11 @@ public class GlobalExceptionHandler {
     @ExceptionHandler(value = Exception.class)
     private Result<String> exceptionHandler(Exception e) {
         logError(e);
-        return Result.failure(SeatunnelErrorEnum.UNKNOWN);
+        return Result.failure(SeatunnelErrorEnum.UNKNOWN, e.getMessage());
     }
 
     private void logError(Throwable throwable) {
-        log.error("", throwable);
+        log.error(throwable.getMessage(), throwable);
     }
 
 }