You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/10 14:28:15 UTC

[GitHub] [beam] ryanthompson591 commented on a diff in pull request #17773: [BEAM-14524] Returning NamedTuple from RunInference transform

ryanthompson591 commented on code in PR #17773:
URL: https://github.com/apache/beam/pull/17773#discussion_r894588323


##########
sdks/python/apache_beam/ml/inference/api.py:
##########
@@ -55,5 +54,9 @@ class RunInference(beam.PTransform):
   def __init__(self, model_loader: base.ModelLoader):
     self._model_loader = model_loader
 
+  @classmethod
+  def create(cls, model_loader_provider, **kwargs):

Review Comment:
   Is this an standard xlang interface that users would expect? I don't really understand it or how it would work.
   
   What do you think about adding a comment to explain why this exists.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org