You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/05 17:20:56 UTC

[GitHub] [incubator-tvm] anijain2305 commented on issue #4828: [QNN][TFLite] TFLite rounding mode support

anijain2305 commented on issue #4828: [QNN][TFLite] TFLite rounding mode support
URL: https://github.com/apache/incubator-tvm/pull/4828#issuecomment-595347242
 
 
   Good finding @LiangHao151941 
   
   I don't think we should add tflite_mode attr to Pool2D op. It seems adhoc to me.
   
   I think we can directly implement the UPWARD rounding in pooling, **whenever the datatype is interger**. For integer division, it is valid to implement rounding by default.
   
   If the tests fail for integer pool, we can change those tests as well. I added those tests in https://github.com/apache/incubator-tvm/pull/3607. Prior to that integer computation in pooling was wrong.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services