You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Stephan Erb <st...@dev.static-void.de> on 2015/07/01 13:59:55 UTC
Re: Review Request 35990: Map Aurora task metadata to Mesos task
labels
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review90041
-----------------------------------------------------------
For sake of transparency: Turns out not everyone thinks this is a great idea. For details, see: https://github.com/prometheus/mesos_exporter/issues/7
- Stephan Erb
On June 30, 2015, 9:36 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 9:36 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Map Aurora task metadata to Mesos task labels
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e934f570e4a728470408970485abe0809487d312
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9
>
> Diff: https://reviews.apache.org/r/35990/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 35990: Map Aurora task metadata to Mesos task
labels
Posted by Bill Farner <wf...@apache.org>.
> On July 1, 2015, 11:59 a.m., Stephan Erb wrote:
> > For sake of transparency: Turns out not everyone thinks this is a great idea. For details, see: https://github.com/prometheus/mesos_exporter/issues/7
Would it be reasonable to impose namespacing of labels, and expect the downstream consumer to use globbing if they want to consume data that spans namespaces?
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review90041
-----------------------------------------------------------
On June 30, 2015, 7:36 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 7:36 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Map Aurora task metadata to Mesos task labels
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e934f570e4a728470408970485abe0809487d312
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9
>
> Diff: https://reviews.apache.org/r/35990/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>
Re: Review Request 35990: Map Aurora task metadata to Mesos task
labels
Posted by Stephan Erb <st...@dev.static-void.de>.
> On July 1, 2015, 1:59 p.m., Stephan Erb wrote:
> > For sake of transparency: Turns out not everyone thinks this is a great idea. For details, see: https://github.com/prometheus/mesos_exporter/issues/7
>
> Bill Farner wrote:
> Would it be reasonable to impose namespacing of labels, and expect the downstream consumer to use globbing if they want to consume data that spans namespaces?
Yeah, I guess namespacing should solve the issue. Unless of course people start to use way to many labels, but I guess Mesos/Aurora will run into problems long before the monitoring solution does.
- Stephan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35990/#review90041
-----------------------------------------------------------
On June 30, 2015, 9:36 p.m., Stephan Erb wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35990/
> -----------------------------------------------------------
>
> (Updated June 30, 2015, 9:36 p.m.)
>
>
> Review request for Aurora, Bill Farner and Zameer Manji.
>
>
> Bugs: AURORA-1052
> https://issues.apache.org/jira/browse/AURORA-1052
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Map Aurora task metadata to Mesos task labels
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java e934f570e4a728470408970485abe0809487d312
> src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java 1b2a7948ebb946a2e12b0eded6acf4ce3c8e20f9
>
> Diff: https://reviews.apache.org/r/35990/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq build
>
>
> Thanks,
>
> Stephan Erb
>
>