You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/04/22 00:34:08 UTC

[GitHub] [echarts] plainheart commented on pull request #14737: fix(marker): add missing type for symbolOffset, fix symbolOffset & symbolKeepAspect doesn't work in markPoint.

plainheart commented on pull request #14737:
URL: https://github.com/apache/echarts/pull/14737#issuecomment-824452971


   Currently, the logic about parsing `symbolOffset` with `numberUtil.parsePercent` and `symbolSize` is used in many places. I'm thinking to extract it into a common helper to reduce redundant code and bundled size.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org