You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Tim Ellison (JIRA)" <ji...@apache.org> on 2009/07/13 14:07:14 UTC

[jira] Commented: (HARMONY-6265) [classlib][luni] Improve the performance of HashMap

    [ https://issues.apache.org/jira/browse/HARMONY-6265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12730308#action_12730308 ] 

Tim Ellison commented on HARMONY-6265:
--------------------------------------

Jim, why is this not a simple rollback of HARMONY-6237 with a fix to #areEqualKeys ?

As I see it, this will definitely improve the situation for Proxies (which I agree should not be a special case), but will have a problem with removing Proxies if the '=' test as well as equals() test is required.


> [classlib][luni] Improve the performance of HashMap 
> ----------------------------------------------------
>
>                 Key: HARMONY-6265
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6265
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>    Affects Versions: 5.0M10
>            Reporter: Jim Yu
>            Assignee: Tim Ellison
>             Fix For: 5.0M11
>
>         Attachments: HARMONY-6265.diff
>
>
> Currently, Proxy.isProxyClass is used in findNonNullKeyEntry method to judge whether a key object is a proxy object or not. However, that will degrade the performance of HashMap since isProxyClass method is synchronized. Actually,  Proxy.isProxyClass can be removed if we use an improved solution to support proxy object as the key.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.