You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/11 06:07:46 UTC

[GitHub] [apisix-docker] tokers commented on a change in pull request #99: feat: add dockerfile for apisix and dashboard with all dependencies

tokers commented on a change in pull request #99:
URL: https://github.com/apache/apisix-docker/pull/99#discussion_r540712866



##########
File path: all-in-one/apisix-dashboard/Dockerfile
##########
@@ -0,0 +1,122 @@
+FROM openresty/openresty:alpine-fat AS production-stage
+
+ARG APISIX_VERSION=master
+LABEL apisix_version="${APISIX_VERSION}"
+
+
+RUN set -x \

Review comment:
       According to the [Dockerfile Best Practices](https://docs.docker.com/develop/develop-images/dockerfile_best-practices):
   
   > Split long or complex RUN statements on multiple lines separated with backslashes to make your Dockerfile more readable, understandable, and maintainable.
   
   We should avoid these long and complex Run statements.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org