You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/02 09:56:11 UTC

[GitHub] [iotdb] caozj1011 opened a new pull request, #8307: [TO rel/1.0] upgrade audit log model

caozj1011 opened a new pull request, #8307:
URL: https://github.com/apache/iotdb/pull/8307

   1. added whether to enable audit logs during open session.
   2. replace the original AUDIT_LOGGER.
   3. when the Audit log level is set to LOGGER, the write operation is changed from DEBUG to INFO.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] caozj1011 closed pull request #8307: [TO rel/1.0] upgrade audit log module

Posted by GitBox <gi...@apache.org>.
caozj1011 closed pull request #8307: [TO rel/1.0] upgrade audit log module
URL: https://github.com/apache/iotdb/pull/8307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a diff in pull request #8307: [TO rel/1.0] upgrade audit log module

Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #8307:
URL: https://github.com/apache/iotdb/pull/8307#discussion_r1040667652


##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -1072,4 +1072,12 @@
 # enable_influxdb_rpc_service=false
 
 # Datatype: int
-# influxdb_rpc_port=8086
\ No newline at end of file
+# influxdb_rpc_port=8086
+

Review Comment:
   ```suggestion
   ####################
   ### Audit Logs Configuration
   ####################
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] caozj1011 closed pull request #8307: [TO rel/1.0] upgrade audit log module

Posted by GitBox <gi...@apache.org>.
caozj1011 closed pull request #8307: [TO rel/1.0] upgrade audit log module
URL: https://github.com/apache/iotdb/pull/8307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a diff in pull request #8307: [TO rel/1.0] upgrade audit log module

Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #8307:
URL: https://github.com/apache/iotdb/pull/8307#discussion_r1040667652


##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -1072,4 +1072,12 @@
 # enable_influxdb_rpc_service=false
 
 # Datatype: int
-# influxdb_rpc_port=8086
\ No newline at end of file
+# influxdb_rpc_port=8086
+

Review Comment:
   ```suggestion
   ####################
   ### Audit Logs Configuration
   ####################
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a diff in pull request #8307: [TO rel/1.0] upgrade audit log module

Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #8307:
URL: https://github.com/apache/iotdb/pull/8307#discussion_r1040670739


##########
server/src/main/java/org/apache/iotdb/db/client/DataNodeInternalClient.java:
##########
@@ -78,7 +78,8 @@ public DataNodeInternalClient(SessionInfo sessionInfo) {
           session,
           sessionInfo.getUserName(),
           sessionInfo.getZoneId(),
-          IoTDBConstant.ClientVersion.V_0_13);
+          IoTDBConstant.ClientVersion.V_0_13,
+          true);

Review Comment:
   Does `select into` need the audit logs?  @JackieTien97 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org