You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/10/24 13:31:32 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #3784: HBASE-26392 Update ClassSize.BYTE_BUFFER for JDK17

Apache9 commented on a change in pull request #3784:
URL: https://github.com/apache/hbase/pull/3784#discussion_r735119632



##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/ClassSize.java
##########
@@ -257,7 +257,11 @@ public static boolean useUnsafeLayout() {
     LINKEDLIST_ENTRY = align(OBJECT + (2 * REFERENCE));
 
     //noinspection PointlessArithmeticExpression
-    BYTE_BUFFER = align(OBJECT + REFERENCE +
+    BYTE_BUFFER = Float.parseFloat(System.getProperty("java.specification.version")) < 17 ?

Review comment:
       Better abstract a util method in JVM class(it is under hbase-common, o.a.h.h.util package) for getting the current jdk version?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org