You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2018/01/23 13:39:10 UTC
[GitHub] carbondata pull request #1850: [CARBONDATA-2069] Restrict create datamap whe...
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1850
[CARBONDATA-2069] Restrict create datamap when load is in progress
**Problem:**
1. Load data into maintable
2. create datamap parallelly
preaggregate table will not have any data while data load is successful for main table. This will make the pre-aggregate table inconsistent
**Solution:** Restrict creation of pre-aggregate table when load is in progress on main table
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [X] Any interfaces changed?
- [X] Any backward compatibility impacted?
- [X] Document update required?
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata restrict_create
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1850.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1850
----
commit 0e47c0e8841c1e0f1ec0291c18d7c7caea2f58aa
Author: kunal642 <ku...@...>
Date: 2018-01-23T13:22:48Z
restrict create datamap when load is in progress
----
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1850
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3103/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3124/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3062/
---
[GitHub] carbondata pull request #1850: [CARBONDATA-2069] Restrict create datamap whe...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1850#discussion_r163639577
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/preaaggregate/CreatePreAggregateTableCommand.scala ---
@@ -157,8 +157,11 @@ case class CreatePreAggregateTableCommand(
// need to fire load for pre-aggregate table. Therefore reading the load details for PARENT
// table.
val loadAvailable = SegmentStatusManager.readLoadMetadata(parentTable.getMetaDataFilepath)
- .nonEmpty
- if (loadAvailable) {
+ if (loadAvailable.exists(load => load.getSegmentStatus == SegmentStatus.INSERT_IN_PROGRESS ||
--- End diff --
I think you should call `DataLoadingUtil.deleteLoadsAndUpdateMetadata(isForceDeletion = false, table)` before checking to make sure stale in-progress loads are removed and updated the status file
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1850
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3053/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3128/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1850
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3065/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1850
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3104/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1850
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3102/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1850
retest this please
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1850
retest this please
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3118/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3126/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1886/
---
[GitHub] carbondata pull request #1850: [CARBONDATA-2069] Restrict create datamap whe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1850
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1893/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1850
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3097/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1895/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1845/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1864/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1830/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3095/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/1892/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1850
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/3076/
---
[GitHub] carbondata issue #1850: [CARBONDATA-2069] Restrict create datamap when load ...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1850
LGTM
---