[GitHub] [nutch] lewismc commented on pull request #691: WIP NUTCH-2883 Provide means to run server and webapp as persistent services in Docker container

[GitBox <gi...@apache.org>]

lewismc commented on pull request #691:
URL: https://github.com/apache/nutch/pull/691#issuecomment-869830352


   Something I would like feedback on is whether we want to run `startserver` and/or `webapp` by default? That is the behaviour implemented in this PR.
   
   I haven't found a way to make this conditional i.e. if we were to build the image as follows 
   ```bash
   docker build -t apache/nutch . --build-arg startserver=true --build-arg webapp=true
   ```
   Then we would expose the ports (these could also be configurable) by implementing `--build-arg server_port=XXXX --build-arg webapp_port=XXXX` and also activate the `ENTRYPOINT` for `supervisord`.
   
   Also, it's important for me to mention that I am aware of the one-service-one-container rule. The reason I chose to try supervisord in this case was that these services are entirely complimentary... I didn't see the reason to complicate things further by using `docker-compose`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@nutch.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org