You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/10/06 02:42:54 UTC
Re: Review Request 38877: Added functionality for Subscribe/Subscribed
workflow for HTTP executors
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38877/#review101565
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On Sept. 30, 2015, 6:06 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38877/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 6:06 a.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-3515
> https://issues.apache.org/jira/browse/MESOS-3515
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the functionality for executors to `Subscribe` via the `api/v1/executor` endpoint. It also stores a marker file as part of the `Subscribe` call if framework `checkpointing` is enabled. This can then be used by the agent when recovering to wait for reconnecting back with the executor.
>
> Since `Call::Update` is in progress as part of MESOS-3476. I have added a `CHECK` if a executor tries to send a list of unacknowledged tasks as part of the `Subscribe` call.
>
>
> Diffs
> -----
>
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
> src/slave/slave.hpp 18be4f8188ad34ef4d0aa4b5eba241053d071476
> src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c
>
> Diff: https://reviews.apache.org/r/38877/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>