You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aurora.apache.org by Mark Chu-Carroll <mc...@twitter.com> on 2013/12/17 17:46:02 UTC
Review Request 16325: Client v2: add support for options shared between
verbs.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16325/
-----------------------------------------------------------
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Repository: aurora
Description
-------
Client v2: add support for options shared between verbs.
Diffs
-----
src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
src/main/python/twitter/aurora/client/cli/options.py PRE-CREATION
Diff: https://reviews.apache.org/r/16325/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 16325: Client v2: add support for options shared between
verbs.
Posted by Brian Wickman <wi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16325/#review30576
-----------------------------------------------------------
src/main/python/twitter/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/16325/#comment58561>
kill the extra space.
also w/in the commons we tend to just intermix both 'import baz' and 'from foo import bar' styles, though i'm not particularly militant about it.
src/main/python/twitter/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/16325/#comment58562>
how is this different from an argparse.Action?
- Brian Wickman
On Dec. 17, 2013, 4:46 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16325/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 4:46 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Client v2: add support for options shared between verbs.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
> src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
> src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
> src/main/python/twitter/aurora/client/cli/options.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16325/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16325: Client v2: add support for options shared between
verbs.
Posted by Brian Wickman <wi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16325/#review30715
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Dec. 17, 2013, 11:37 p.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16325/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 11:37 p.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Client v2: add support for options shared between verbs.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
> src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
> src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
> src/main/python/twitter/aurora/client/cli/options.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16325/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>
Re: Review Request 16325: Client v2: add support for options shared between
verbs.
Posted by Mark Chu-Carroll <mc...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16325/
-----------------------------------------------------------
(Updated Dec. 17, 2013, 6:37 p.m.)
Review request for Aurora, Jonathan Boulle and Brian Wickman.
Changes
-------
Address review.
Repository: aurora
Description
-------
Client v2: add support for options shared between verbs.
Diffs (updated)
-----
src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
src/main/python/twitter/aurora/client/cli/options.py PRE-CREATION
Diff: https://reviews.apache.org/r/16325/diff/
Testing
-------
Thanks,
Mark Chu-Carroll
Re: Review Request 16325: Client v2: add support for options shared between
verbs.
Posted by Mark Chu-Carroll <mc...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16325/#review30580
-----------------------------------------------------------
src/main/python/twitter/aurora/client/cli/__init__.py
<https://reviews.apache.org/r/16325/#comment58569>
Unless I misunderstood the docs, an action doesn't specify a command-line parameter - it just provides an executable behavior to perform when an option is passed. It's one of the optional parameters to add_argument.
This is just a wrapper to save the parameters for add_argument in a reusable box.
- Mark Chu-Carroll
On Dec. 17, 2013, 11:46 a.m., Mark Chu-Carroll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16325/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2013, 11:46 a.m.)
>
>
> Review request for Aurora, Jonathan Boulle and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Client v2: add support for options shared between verbs.
>
>
> Diffs
> -----
>
> src/main/python/twitter/aurora/client/cli/BUILD aaeede4ac0b1239c1cb9354d15365658e1650ec8
> src/main/python/twitter/aurora/client/cli/__init__.py 4b771d61464cfa2256d48f0a71ddd5829dd27266
> src/main/python/twitter/aurora/client/cli/jobs.py 58a723fbc5591565fd51311e0dcfa9567282dbb3
> src/main/python/twitter/aurora/client/cli/options.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/16325/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mark Chu-Carroll
>
>