You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/25 18:45:04 UTC

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

Hannah-Jiang commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies
URL: https://github.com/apache/beam/pull/11067#discussion_r398088883
 
 

 ##########
 File path: licenses/go/bufio/LICENSE
 ##########
 @@ -0,0 +1,27 @@
+Copyright (c) 2009 The Go Authors. All rights reserved.
 
 Review comment:
   > > I'll second the comment that we should not include the list of license files in the beam repository itself, but just add the script to the container build process to install them into the container.
   > 
   > I agree. It would seem better for all languages to add the license retrieval to the container build script.
   
   I will make this change in the next commit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services