You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/04/09 14:58:00 UTC
[jira] [Commented] (TINKERPOP-2195) Add finally block in
HttpGremlinEndpointHandler to commit transaction
[ https://issues.apache.org/jira/browse/TINKERPOP-2195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813509#comment-16813509 ]
ASF GitHub Bot commented on TINKERPOP-2195:
-------------------------------------------
moayad86 commented on pull request #1094: TINKERPOP-2195: Add finally block in HttpGremlinEndpointHandler to commit transaction
URL: https://github.com/apache/tinkerpop/pull/1094
https://issues.apache.org/jira/browse/TINKERPOP-2195
An improvement is to do the serialisation first, and add a finally block to the try...catch statement, where transaction commit can take place. More information in the ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Add finally block in HttpGremlinEndpointHandler to commit transaction
> ---------------------------------------------------------------------
>
> Key: TINKERPOP-2195
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2195
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.4.2
> Reporter: Moayad Alyaghshi
> Priority: Major
>
> The HttpGremlinEndpointHandler is attempting to commit the transaction before serialisation to be consistent with how things work for websocket, so the transaction will be committed regardless of the serialisation result.
> This's causing a performance problem to our implementation which depends on JPA, because serialisation will require to read the entities again from the database since the transaction has been committed and the objects are still managed by the entity manager.
> An improvement is to do the serialisation first, and add a finally block to the try...catch statement, where transaction commit can take place.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)