[GitHub] [dubbo-samples] zrlw commented on a change in pull request #352: modified dubbo-samples-nacos-configcenter for dubbo#8217

[GitBox <gi...@apache.org>]

zrlw commented on a change in pull request #352:
URL: https://github.com/apache/dubbo-samples/pull/352#discussion_r681719394



##########
File path: dubbo-samples-nacos/dubbo-samples-nacos-configcenter/src/test/java/org/apache/dubbo/samples/configcenter/DemoServiceIT.java
##########
@@ -19,19 +19,19 @@
 
 import org.apache.dubbo.samples.configcenter.api.DemoService;
 
+import org.apache.dubbo.config.annotation.Reference;
+import org.apache.dubbo.config.spring.context.annotation.EnableDubbo;
 import org.junit.Assert;
 import org.junit.Test;
 import org.junit.runner.RunWith;
-import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.test.context.ContextConfiguration;
 import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
 
 @RunWith(SpringJUnit4ClassRunner.class)
 @ContextConfiguration(locations = "classpath:spring/configcenter-consumer.xml")
+@EnableDubbo

Review comment:
       These changing is for regression test. if not changing,  a ClassCastException will not be trigged running with dubbo 2.7.12 or prior version.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org